fix: remove unnecessary 'asChild' prop from FilterButton component by dcc123456 · Pull Request #16094 · infiniflow/ragflow (original) (raw)

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 68ed1e28-ec01-4b60-96a3-c01a839d01db

📥 Commits

Reviewing files that changed from the base of the PR and between 1feb1c4 and 1022358.

📒 Files selected for processing (1)

📝 Walkthrough

Walkthrough

FilterButton removes the asChild prop from its inner Button component, disabling the child-wrapping render behavior. A minor JSX whitespace adjustment is made at the boundary between the FilterPopover and showSearch conditionals in ListFilterBar, with no functional changes.

Changes

FilterButton asChild removal

Layer / File(s) Summary
Remove asChild and JSX whitespace web/src/components/list-filter-bar/index.tsx FilterButton no longer passes asChild to Button, so child-wrapping rendering is disabled. The line boundary between FilterPopover and the showSearch conditional is reformatted without logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops and clips the prop,
asChild falls off—no need to stop.
The button wraps itself no more,
just spreads its props like before.
🐇 Less is more, says the warren lore!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description includes the required 'What problem does this PR solve?' section and 'Type of change' section with Bug Fix selected, but lacks substantive detail about the actual problem being solved. Add more context about why the 'asChild' prop was unnecessary and what issue its removal fixes to help reviewers understand the motivation.

✅ Passed checks (4 passed)

Check name Status Explanation
Title check ✅ Passed The PR title accurately describes the main change: removing the unnecessary 'asChild' prop from FilterButton, which is directly reflected in the code summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.