add precision column stat_string and different table names by Melkiades · Pull Request #986 · insightsengineering/rtables (original) (raw)

@Melkiades

@github-actions

@github-actions

Unit Tests Summary

1 files 28 suites 1m 35s ⏱️
220 tests 220 ✅ 0 💤 0 ❌
1 586 runs 1 586 ✅ 0 💤 0 ❌

Results for commit a79baf6.

♻️ This comment has been updated with latest results.

@github-actions

Unit Test Performance Difference

Test Suite StatusStatusStatus Time on main ±Time±Time±Time ±Tests±Tests±Tests ±Skipped±Skipped±Skipped ±Failures±Failures±Failures ±Errors±Errors±Errors
Result Data Frames 💔 7.137.137.13 +2.31+2.31+2.31 +7+7+7 000 000 000

Additional test case details

Test Suite StatusStatusStatus Time on main ±Time±Time±Time Test Case
Result Data Frames 👶 +0.72+0.72+0.72 make_ard_works_if_string_precision_is_needed
Result Data Frames 👶 +0.18+0.18+0.18 make_ard_works_with_split_cols_by_multivar

Results for commit c83e988

♻️ This comment has been updated with latest results.

@Melkiades

@Melkiades Melkiades linked an issue

Jan 27, 2025

that may beclosed by this pull request

@Melkiades

@Melkiades Melkiades linked an issue

Jan 27, 2025

that may beclosed by this pull request

@github-actions

@Melkiades

edelarua

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!! Thanks Davide! Just one typo in the NEWS file to correct.

@Melkiades @edelarua

Co-authored-by: Emily de la Rua 59304861+edelarua@users.noreply.github.com Signed-off-by: Davide Garolini dgarolini@gmail.com

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})