Fix formatted values different from cell values by Melkiades · Pull Request #988 · insightsengineering/rtables (original) (raw)
Fix #987 (variables handling to improve)
Unit Tests Summary
1 files 28 suites 1m 40s ⏱️
221 tests 221 ✅ 0 💤 0 ❌
1 588 runs 1 588 ✅ 0 💤 0 ❌
Results for commit c4af0eb.
♻️ This comment has been updated with latest results.
Unit Test Performance Difference
| Test Suite | StatusStatusStatus | Time on main | ±Time±Time±Time | ±Tests±Tests±Tests | ±Skipped±Skipped±Skipped | ±Failures±Failures±Failures | ±Errors±Errors±Errors |
|---|---|---|---|---|---|---|---|
| Tabulation framework | 💔 | 19.7919.7919.79 | +1.12+1.12+1.12 | 000 | 000 | 000 | 000 |
Additional test case details
| Test Suite | StatusStatusStatus | Time on main | ±Time±Time±Time | Test Case |
|---|---|---|---|---|
| Result Data Frames | 👶 | +0.16+0.16+0.16 | make_ard_works_when_printed_format_differs_from_cell_values |
Results for commit 2f7825e
♻️ This comment has been updated with latest results.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! Just a few suggestions from me to make the messaging more concise. Thanks Davide :)
If you need to make more changes to fix the tests and need a re-review let me know!!
Co-authored-by: Emily de la Rua edelarua@uwaterloo.ca Signed-off-by: Davide Garolini dgarolini@gmail.com
Co-authored-by: Emily de la Rua edelarua@uwaterloo.ca Signed-off-by: Davide Garolini dgarolini@gmail.com
Co-authored-by: Emily de la Rua edelarua@uwaterloo.ca Signed-off-by: Davide Garolini dgarolini@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})