Resolve address sanitizer issues in runtime unit test by sophimao · Pull Request #154 · intel/fpga-runtime-for-opencl (original) (raw)

While I was fixing the issue, I found that the condition on acl_mem.cpp:1631 seems exactly like the previous condition on lines 1624-1625. Should that be an is_image condition?

Thanks Sophie, good catch! Looking at the list of possible memory object types, can these two cases be combined to a single case, image_desc->mem_object != NULL and Do not support images created from other memory objects?

I guess we could do that. I'm wondering what's the original intend of having two separate conditions though, perhaps we are thinking of supporting those two cases one by one? If we do want to look into supporting that, maybe it's good to keep an investigation note somewhere.