Delay erasing context from contexts_set during acl_idle_update by sophimao · Pull Request #322 · intel/fpga-runtime-for-opencl (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

This repository was archived by the owner on Mar 2, 2026. It is now read-only.

Merged

sophimao

merged 1 commit into

Oct 24, 2023

Conversation

@sophimao

Fixes issue where context is being deleted from contexts_set while traversing through the same context_set, causing undefined behaviour and sometimes crash in acl_idle_update.

@sophimao sophimao marked this pull request as ready for review

October 18, 2023 19:03

zibaiwan

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sophie. Looks good except a minor comment.

@sophimao

Fixes issue where context is being deleted from contexts_set while traversing through the same context_set, causing undefined behaviour and sometimes crash in acl_idle_update.

zibaiwan

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

2 participants

@sophimao @zibaiwan