CPUID handling code refactoring by nevilad · Pull Request #245 · intel/haxm (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have further question on this PR. Please:
1). Remove the zeroing out of state->_ecx.
2). Do not add PDPE1GB, LAHF and PREFETCHW in this patch. Leave this one as pure handle_cpuid_virtual() refactoring and draft another patch to add them, so that we can bisect if any issue found.
3). Describe in commit message what you did in this patch.

Force update your repo and I'll merge it.

And draft another patch by simply adding DPE1GB, LAHF and PREFETCHW.