Fix NetBSD build and add support for HAX_VCPU_IOCTL_SET_CPUID by krytarowski · Pull Request #281 · intel/haxm (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not create a function?

This pair of function-like macros are designed for all interfaces with variable-length arguments. As there are types, struct members in the macro parameters, it is hard to define a real function to handle these cases. But I agree to bring the definition to a common place, such as hax.h, instead of duplicating the codes here.

Linux + Darwin use macro here.

As for the minor difference between NetBSD/Darwin and Linux, should we merge them into one macro by platform switch?