Remove legacy VTLB engine by wcwang · Pull Request #386 · intel/haxm (original) (raw)

As the new memory virtualization engine EPT2 (Extended Page Table) has been stable, the VTLB codes are deprecated.

Change summary:

• Removes the VTLB implementation and header files, and update the project files for 4 platforms;
• Removes the related variables in other modules and redundant memory allocation for VTLB structure;
• Adds the MMIO module to manage MMIO related functions.

As the new memory virtualization engine EPT2 (Extended Page Table) has been stable, the VTLB codes are deprecated.

Change summary:

• Removes the VTLB implementation and header files, and update the project files for 4 platforms;
• Removes the related variables in other modules and redundant memory allocation for VTLB structure;
• Adds the MMIO module to manage MMIO related functions.

Signed-off-by: Wenchao Wang wenchao.wang@intel.com

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If mmio.h and mmio.c are not related with VTLB code clean, better submit in another commit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your careful review. These MMIO functions had already existed in VTLB module before. All functions will be invoked by vCPU module currently, so they cannot be omitted because of build reason. All changes this time are atomic. For more details, see the comments at line 727 in previous vtlb.c.