Fix minor bugs and clippy warnings by kpcyrd · Pull Request #200 · kpcyrd/rebuilderd (original) (raw)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves code quality through refactoring and cleanup, including removing unnecessary references, improving error handling, and streamlining function signatures.
Key changes:
- Changed function parameters from
&Stringto&strfor better idiomatic Rust - Removed conditional worker registration (now always attempts registration with better error context)
- Added status filtering for the package listing command
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| worker/src/main.rs | Removed unnecessary references, made worker registration unconditional with improved error handling |
| tools/src/schedule/tails.rs | Removed unnecessary dereferences in function calls |
| tools/src/schedule/debian.rs | Changed parameter types from &String to &str, updated test code to use string literals instead of unnecessary allocations |
| tools/src/main.rs | Added status filtering logic, removed unnecessary reference, prefixed unused variable |
| tools/src/args.rs | Updated import from BuildStatus to ArtifactStatus, simplified PkgsSyncStdin struct |
| daemon/src/config.rs | Added .truncate(true) to ensure auth cookie file is properly overwritten |
| contrib/systemd/rebuilderd-worker@.service | Added environment variable configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.