feat: Add specialized handler for tool calling improvements by Cristhianzl · Pull Request #10857 · langflow-ai/langflow (original) (raw)

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This change introduces IBM WatsonX/Granite-specific tool calling support with model detection, enhanced system prompts for multi-tool scenarios, placeholder detection in tool arguments, and a dynamic agent creator that alternates tool-choice binding based on iteration depth. The feature integrates into the existing tool-calling pipeline and is covered by comprehensive unit tests.

Changes

Sequence Diagram(s)

sequenceDiagram participant Client participant ToolCalling participant GraniteHandler participant LLM participant Agent participant Tools

Client->>ToolCalling: create_agent_runnable(llm, tools, prompt)

rect rgb(200, 220, 240)
Note over ToolCalling,GraniteHandler: Granite Model Detection & Prompt Enhancement
ToolCalling->>GraniteHandler: is_granite_model(llm)
GraniteHandler-->>ToolCalling: bool result

alt Granite Model Detected
    ToolCalling->>GraniteHandler: get_enhanced_system_prompt(base_prompt, tools)
    GraniteHandler-->>ToolCalling: enhanced_prompt with tool instructions
end
end

rect rgb(240, 220, 200)
Note over ToolCalling,Agent: Agent Creation
alt Granite Model with Tools
    ToolCalling->>GraniteHandler: create_granite_agent(llm, tools, prompt)
    
    loop For Each Iteration
        rect rgb(220, 240, 220)
        Note over GraniteHandler,LLM: Dynamic Tool Choice Binding
        GraniteHandler->>LLM: Select tool_choice (required/auto based on iteration)
        LLM->>LLM: Bind tools with selected tool_choice
        end
        
        GraniteHandler->>LLM: Invoke with input & agent_scratchpad
        LLM-->>GraniteHandler: tool_call or response
        
        GraniteHandler->>GraniteHandler: detect_placeholder_in_args(tool_calls)
        
        alt Placeholder Detected
            GraniteHandler->>GraniteHandler: Inject corrective SystemMessage
        end
        
        GraniteHandler->>Tools: Execute tool_calls
        Tools-->>GraniteHandler: tool results
    end
    
    GraniteHandler-->>ToolCalling: RunnableLambda agent
else Default Model
    ToolCalling->>Agent: create_tool_calling_agent(llm, tools, prompt)
    Agent-->>ToolCalling: default agent
end
end

ToolCalling-->>Client: agent_runnable

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30–45 minutes

• ibm_granite_handler.py: New module with multiple interconnected functions; the create_granite_agent function contains complex logic around dynamic LLM binding, iteration tracking, and placeholder detection that warrants careful review.
• Placeholder detection patterns: The PLACEHOLDER_PATTERN regex and detect_placeholder_in_args logic should be validated against the test cases to ensure correctness.
• Dynamic tool-choice switching: The iteration-depth-based toggling between tool_choice="required" and tool_choice="auto" in dynamic_invoke needs verification of state management and conditional routing.
• Integration points in tool_calling.py: While straightforward, confirm that Granite-specific branching does not inadvertently affect non-Granite model paths.
• Test file scope: The extensive test module (800+ lines) is thorough but should be spot-checked for coverage of edge cases, especially around nested/mock structures and mixed-case matching.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

✅ Passed checks (6 passed)

✨ Finishing touches 🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cz/improve-ibm-models

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.