linux support using liburing by Garcia6l20 · Pull Request #169 · lewissbaker/cppcoro (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits21 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
- CMake support
- io operations using liburing
- supports schedule operation
- file_read example with liburing
- (timed_)schedule_operation ok
- file_read_operation ok
- file access generic handling
- fix dangling references to io_vec
- catching uring errors (thrown in io_service corouting)
- required kernel version 5.4 (5.5 for connect/accept operations)
- moved stdcoro.hpp into detail sub-folder
- fix:
for co_awaitremoved from C++20 - fix: uring operation with offset handling
- impl:
cppcoro:🥅:socket_disconnect_operation_impl - fix: naming collusion with
socket - fix:
GENERIC_WRITEdefinition for write_only_file
- fix: io_service cancellation
- fix: increased max_events in
io_service_fixture
- remaining deadlock in io_service_tests: multiple I/O threads servicing events
- ERROR_MORE_DATA emulation using MSG_TRUNC
- mutext protection of sge and cqe
All tests are passing on GCC11.when_all() with all task types test fails on GCC10 because extra construction are done, 2 moves an 1 copy (GCC bug ???).
if someone can tell me how check for header and add compile definitions with cake it could probably help me fixing CI
Hi, thanks a lot for sharing your code. How does your contribution compare to #160?
Hi, thanks a lot for sharing your code. How does your contribution compare to #160?
It includes what 160 does not. Timed scheduling and network.
I actually did not saw that other PR.
@Garcia6l20 thanks again for your work. It would be great to see liburing support integrated. Your pull request addresses many different problems at once, which makes it difficult to review. It also solves problems which have already been solved in other pull requests. In the cppcoro fork at https://github.com/andreasbuhr/cppcoro I started an effort to merge the contributions from the different existing pull requests and solve only one problem at a time. One of the first steps should be to add CMake support. In https://github.com/andreasbuhr/cppcoro/tree/add_cmake_support I created a branch which does nothing but adding CMake support, based on the different pull requests which exist here. I'd like to invite you to help make it better. Once it is in a good shape, we can add a new pull request which can then (hopefully) be easily merged by Lewis. And then care about the next issue.
@andreasbuhr Sounds great !
I would be pleased to help you.
I know I did it a bit fast but I wanted to see cppcoro in action :)
I'll close this PR and restart from your cmake branch step by step.
arthurzam added a commit to arthurzam/cppcoro that referenced this pull request
2 participants
