Fix bug where GTPushTransferProgressBlock is unused by dleehr · Pull Request #508 · libgit2/objective-git (original) (raw)

In pushRefspecs:toRemote:withOptions, the remote_callbacks struct was incorrectly configured and the push_transfer_progress callback was not set. This caused the user-provided GTRemotePushTransferProgressBlock to never be used, since it was bound to GTRemotePushTransferProgressCallback, which was not set in the struct.

This change fixes the bug in objective-git, but there's a very similar bug in libgit2 that results in the callback only being called once for smart protocol pushes, at the end - fixed in libgit2/libgit2#3377