Namespace inline mismatch diagnostic refers to unhelpful previous definition · Issue #50794 · llvm/llvm-project (original) (raw)

Extended Description

See: https://godbolt.org/z/x87K78TnW

Take this C++ code:

1: inline namespace abc {};
2: namespace abc {};
3: namespace abc {};

Clang will emit a warning for line 2, because the namespace is re-opened as non-inline, while the previous definition was inline. It will add a Note for the previous definition, in this case line 1.

However, it will also emit the same warning for line 3. In this case, it would be helpful to have the Note refer to the definition in line 1, but it instead refers to line 2. That is confusing since the problem is the inline mismatch, but the Note refers to a definition that is not inline.