[hexagon] Enable --eh-frame-hdr by androm3da · Pull Request #130225 · llvm/llvm-project (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks16 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The missing PT_GNU_EH_FRAME was causing C++ exception handling test failures in llvm-test-suite. We should unconditionally add this argument like the other drivers do.
Discovered-by: Alexey Karyakin akaryaki@quicinc.com
Fixes: #129745
The missing PT_GNU_EH_FRAME was causing C++ exception handling test
failures in llvm-test-suite. We should unconditionally add this
argument like the other drivers do.
Fixes: llvm#129745
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-backend-hexagon
Author: Brian Cain (androm3da)
Changes
The missing PT_GNU_EH_FRAME was causing C++ exception handling test failures in llvm-test-suite. We should unconditionally add this argument like the other drivers do.
Discovered-by: Alexey Karyakin akaryaki@quicinc.com
Fixes: #129745
Full diff: https://github.com/llvm/llvm-project/pull/130225.diff
3 Files Affected:
- (modified) clang/lib/Driver/ToolChains/Hexagon.cpp (+1)
- (modified) clang/test/Driver/hexagon-toolchain-elf.c (+1)
- (modified) clang/test/Driver/hexagon-toolchain-linux.c (+1)
diff --git a/clang/lib/Driver/ToolChains/Hexagon.cpp b/clang/lib/Driver/ToolChains/Hexagon.cpp index 7ca5ab9af8810..6ea701a7882d1 100644 --- a/clang/lib/Driver/ToolChains/Hexagon.cpp +++ b/clang/lib/Driver/ToolChains/Hexagon.cpp @@ -313,6 +313,7 @@ constructHexagonLinkArgs(Compilation &C, const JobAction &JA, // handled somewhere else. Args.ClaimAllArgs(options::OPT_static_libgcc);
- CmdArgs.push_back("--eh-frame-hdr");
//----------------------------------------------------------------------------
//
//----------------------------------------------------------------------------
diff --git a/clang/test/Driver/hexagon-toolchain-elf.c b/clang/test/Driver/hexagon-toolchain-elf.c
index be812dda40d57..de2ebfeeda26c 100644
--- a/clang/test/Driver/hexagon-toolchain-elf.c
+++ b/clang/test/Driver/hexagon-toolchain-elf.c
@@ -555,6 +555,7 @@
// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin
// RUN: -mcpu=hexagonv60
// RUN: -fuse-ld=lld %s 2>&1 | FileCheck -check-prefix=CHECK382 %s +// CHECK382: "--eh-frame-hdr // CHECK382-NOT: "-march= // CHECK382-NOT: "-mcpu= // -----------------------------------------------------------------------------
diff --git a/clang/test/Driver/hexagon-toolchain-linux.c b/clang/test/Driver/hexagon-toolchain-linux.c
index 6f7f3b20f9141..e791353cca07f 100644
--- a/clang/test/Driver/hexagon-toolchain-linux.c
+++ b/clang/test/Driver/hexagon-toolchain-linux.c
@@ -127,6 +127,7 @@
// RUN: --target=hexagon-unknown-linux-musl %s -### 2>&1
// RUN: | FileCheck -check-prefix=CHECK011 %s
// CHECK011: InstalledDir: [[INSTALLED_DIR:.+]]
+// CHECK011: "--eh-frame-hdr"
// CHECK011: crt1.o
// CHECK011-NOT: "-lunwind"
// CHECK011-NOT: "-lgcc_eh"
@llvm/pr-subscribers-clang-driver
Author: Brian Cain (androm3da)
Changes
The missing PT_GNU_EH_FRAME was causing C++ exception handling test failures in llvm-test-suite. We should unconditionally add this argument like the other drivers do.
Discovered-by: Alexey Karyakin akaryaki@quicinc.com
Fixes: #129745
Full diff: https://github.com/llvm/llvm-project/pull/130225.diff
3 Files Affected:
- (modified) clang/lib/Driver/ToolChains/Hexagon.cpp (+1)
- (modified) clang/test/Driver/hexagon-toolchain-elf.c (+1)
- (modified) clang/test/Driver/hexagon-toolchain-linux.c (+1)
diff --git a/clang/lib/Driver/ToolChains/Hexagon.cpp b/clang/lib/Driver/ToolChains/Hexagon.cpp index 7ca5ab9af8810..6ea701a7882d1 100644 --- a/clang/lib/Driver/ToolChains/Hexagon.cpp +++ b/clang/lib/Driver/ToolChains/Hexagon.cpp @@ -313,6 +313,7 @@ constructHexagonLinkArgs(Compilation &C, const JobAction &JA, // handled somewhere else. Args.ClaimAllArgs(options::OPT_static_libgcc);
- CmdArgs.push_back("--eh-frame-hdr");
//----------------------------------------------------------------------------
//
//----------------------------------------------------------------------------
diff --git a/clang/test/Driver/hexagon-toolchain-elf.c b/clang/test/Driver/hexagon-toolchain-elf.c
index be812dda40d57..de2ebfeeda26c 100644
--- a/clang/test/Driver/hexagon-toolchain-elf.c
+++ b/clang/test/Driver/hexagon-toolchain-elf.c
@@ -555,6 +555,7 @@
// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin
// RUN: -mcpu=hexagonv60
// RUN: -fuse-ld=lld %s 2>&1 | FileCheck -check-prefix=CHECK382 %s +// CHECK382: "--eh-frame-hdr // CHECK382-NOT: "-march= // CHECK382-NOT: "-mcpu= // -----------------------------------------------------------------------------
diff --git a/clang/test/Driver/hexagon-toolchain-linux.c b/clang/test/Driver/hexagon-toolchain-linux.c
index 6f7f3b20f9141..e791353cca07f 100644
--- a/clang/test/Driver/hexagon-toolchain-linux.c
+++ b/clang/test/Driver/hexagon-toolchain-linux.c
@@ -127,6 +127,7 @@
// RUN: --target=hexagon-unknown-linux-musl %s -### 2>&1
// RUN: | FileCheck -check-prefix=CHECK011 %s
// CHECK011: InstalledDir: [[INSTALLED_DIR:.+]]
+// CHECK011: "--eh-frame-hdr"
// CHECK011: crt1.o
// CHECK011-NOT: "-lunwind"
// CHECK011-NOT: "-lgcc_eh"
swift-ci pushed a commit to swiftlang/llvm-project that referenced this pull request
The missing PT_GNU_EH_FRAME was causing C++ exception handling test
failures in llvm-test-suite. We should unconditionally add this argument
like the other drivers do.
Discovered-by: Alexey Karyakin akaryaki@quicinc.com Fixes: llvm#129745 (cherry picked from commit 6657769)