[lldb] Stop testing LLDB on Clang changes in pre-commit CI by Endilll · Pull Request #95537 · llvm/llvm-project (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks9 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This is a temporary measure to alleviate Linux pre-commit CI waiting times that started snowballing recently.
My initial estimate of 4 additional minutes spent per built seems to be in the right ballpark, but looks like that was the last straw to break camel's back. It seems that CI load got past the tipping point, and now it's not able to burn through the queue over the night on workdays.
I don't intend to overthrow the consensus we reached in #94208, but it shouldn't come at the expense of the whole LLVM community. I'll enable this back as soon as we have news that we got more capacity for Linux pre-commit CI.
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
This is a temporary measure to alleviate Linux pre-commit CI waiting times that started snowballing recently.
My initial estimate of 4 additional minutes spent per built seems to be in the right ballpark, but looks like that was the last straw to break camel's back. It seems that CI load got past the tipping point, and now it's not able to burn through the queue over the night on workdays.
I don't intend to overthrow the consensus we reached in #94208, but it shouldn't come at the expense of the whole LLVM community. I'll enable this back as soon as we have news that we got more capacity for Linux pre-commit CI.
Full diff: https://github.com/llvm/llvm-project/pull/95537.diff
1 Files Affected:
- (modified) .ci/generate-buildkite-pipeline-premerge (+2-1)
diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge index fd603de611e56..98a8b8fff3687 100755 --- a/.ci/generate-buildkite-pipeline-premerge +++ b/.ci/generate-buildkite-pipeline-premerge @@ -74,7 +74,8 @@ function compute-projects-to-test() { fi ;; clang)
for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
# lldb is temporarily removed to alleviate Linux pre-commit CI waiting times
;;for p in clang-tools-extra compiler-rt cross-project-tests; do echo $p done
@llvm/pr-subscribers-lldb
Author: Vlad Serebrennikov (Endilll)
Changes
This is a temporary measure to alleviate Linux pre-commit CI waiting times that started snowballing recently.
My initial estimate of 4 additional minutes spent per built seems to be in the right ballpark, but looks like that was the last straw to break camel's back. It seems that CI load got past the tipping point, and now it's not able to burn through the queue over the night on workdays.
I don't intend to overthrow the consensus we reached in #94208, but it shouldn't come at the expense of the whole LLVM community. I'll enable this back as soon as we have news that we got more capacity for Linux pre-commit CI.
Full diff: https://github.com/llvm/llvm-project/pull/95537.diff
1 Files Affected:
- (modified) .ci/generate-buildkite-pipeline-premerge (+2-1)
diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge index fd603de611e56..98a8b8fff3687 100755 --- a/.ci/generate-buildkite-pipeline-premerge +++ b/.ci/generate-buildkite-pipeline-premerge @@ -74,7 +74,8 @@ function compute-projects-to-test() { fi ;; clang)
for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
# lldb is temporarily removed to alleviate Linux pre-commit CI waiting times
;;for p in clang-tools-extra compiler-rt cross-project-tests; do echo $p done
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this as a stopgap measure. @JDevlieghere, are you okay with this as well?
Endilll deleted the disable-lldb-on-clang-changes branch
This was referenced
Mar 20, 2025
Reviewers
mizvekov mizvekov approved these changes
JDevlieghere JDevlieghere approved these changes
AaronBallman AaronBallman approved these changes
tstellar Awaiting requested review from tstellar
DavidSpickett Awaiting requested review from DavidSpickett
lnihlen Awaiting requested review from lnihlen
adrian-prantl Awaiting requested review from adrian-prantl
Michael137 Awaiting requested review from Michael137