Use dafault navigation by maoyama · Pull Request #170

Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Merged

maoyama

merged 1 commit into

Jun 15, 2025

Conversation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches from a custom back button inset to using the default navigation back behavior.

Removed the safeAreaInset with BarBackButton
Dropped the navigationBarBackButtonHidden() modifier Comments suppressed due to low confidence (2)

GitClient/Views/Commit/CommitDetailStackView.swift:19

Consider adding UI tests to validate the default back-navigation behavior now that the custom back button has been removed, ensuring navigationDestination still functions as expected.

.navigationDestination(for: String.self) { commitHash in

GitClient/Views/Commit/CommitDetailStackView.swift:19

[nitpick] Add a brief comment documenting that the default navigation bar back button is now used in place of the custom BarBackButton, to help future maintainers understand this change.

CommitDetailView(commitHash: commitHash, folder: folder)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Use dafault navigation by maoyama · Pull Request #170 · maoyama/Changes (original) (raw)