New properties framework by bjorn · Pull Request #4045 · mapeditor/tiled (original) (raw)
The new property editor will be based on a widget hierarchy instead of a QTreeView. This will allow better customization and direct widget interaction.
This first step implements various property edit widgets which are instantiated based on the type of QVariant values.
- DoubleSpinBox, with precision logic from existing property editor
- Custom spin boxes and combo boxes which shrink horizontally
- Property names elide when there isn't enough space
- QPointF and QColor editor factories
- Includes a test with all built-in map properties
- Supports headers (not collapsible for now)
- Supports separators
- EnumEditorFactory, with support for non-consecutive enums
- Name and editor widgets are stretched by a fixed 2:3 ratio and ignore their size hint
- Includes some start on possible API for setting/getting the value
It adjusts the layout based on its width.
Also made a few other visual tweaks.
Introduced Property class and changed from using editor factories to having the property itself create its widget.
Map size is read-only but features a "Resize Map" button that triggers the resize dialog.
Both map size and tile size are implemented based on the new "ValueTypeEditorFactory" which selects an editor based on the value type. This functionality is moved out of the VariantEditor.
Introduced AbstractProperty, ValueProperty and QObjectProperty in an attempt to provide some convenience on top of the Property interface.
I'm not entirely convinced it was a good idea to put the "createEditor" function on the Property. It makes it easy to do custom widgets for a property, but annoying to have it use a type-based editor.
Introduced MapProperties class to make it easier to emit valueChanged for all the map's properties, as well to move their creation out of PropertiesWidget::currentObjectChanged.
Added GetSetProperty that makes it easier to define a property in terms of a given getter and setter function, since it avoids the need for a specific Property subclass.
Finished implementation of the BoolEditorFactory (signals connected).
Moved property edit widgets to their own file.
Introduced a few helper functions to reduce code duplication, like MapProperties::push.
Disabled properties when they are irrelevant.
Finished connecting the signals for the remaining editor factories: StringEditorFactory, IntEditorFactory, FloatEditorFactory, PointEditorFactory, PointFEditorFactory, RectFEditorFactory and ColorEditorFactory.
This property uses an editable combo box with the valid classes set up for the given object type.
Still needs special handling for:
- Color (requires handling invalid/unset values)
- Widget for editing allowed transformations
- Widget for showing tileset parameters (and trigger edit dialog)
- Specifying 1 as minimum value for column count
Some details remain to be done:
- Changes made to layer properties should apply to all selected layers
- Opacity should probably be a slider now and have appropriate limits
- Step size for opacity and parallax factor is too big
Added support for editing QUrl values using UrlEditorFactory that creates a FileEdit.
Also in this change:
Made SpinBox and DoubleSpinBox don't respond to changing from keyboard typing immediately.
Share a single implementation of wrapping label/widget pairs for SizeEdit, SizeFEdit, PointEdit, PointFEdit and RectFEdit.
Added widget factories for QFont, QSizeF and Qt::Alignment.
Allow setting suffix on custom FloatEditorFactory, used for adding degree symbol to rotation values.
A few things remain to be done:
- Custom widget for editing tile object flipping flags
- Try reducing size of font editor with style toggle buttons
Now all built-in properties are present, apart from some loose ends.
- Added RectEdit / RectEditorFactory (QRect values)
- Added Property::toolTip (set on label and editor, but currently not functional on label due to the eliding tool tip logic)
- Added change events to fix updating of WangSet and WangColor properties (was already broken with old framework)
Instead there are now typed Property subclasses similar to the generic GetSetProperty.
Use a special property that creates a name edit as label and a type combo box as editor, instead of a modal Add Property dialog.
VariantEditorView::focusProperty now makes sure that the focused property widget is visible.
The "add value" property is automatically removed when it loses focus. To achieve this, each property now gets its own parent widget rather than just having its widgets added to a nested horizontal layout. This way, we can check whether the focus remains within the same parent widget.
The Add button has Qt::StrongFocus policy now, otherwise the focus would be lost to the properties view when clicking it.
When changed by other means (scripting, undo/redo, Layers view), the name wasn't updating due to a missing valueChanged call.
We don't really need to put it in a QWidget with a vertical layout.
- Top-level properties can be selected by clicking.
- Holding Ctrl or Shift allows selecting multiple.
- Keyboard handling for selection implemented.
- Remove and Rename actions on tool bar now functional.
- Copy/paste shortcuts work.
As part of implementing this, the VariantEditor and VariantEditorView have been merged into a single PropertiesView class.
ToDo:
- selectedPropertiesChanged may not get emitted when a selected property is removed.
- Add Copy/Paste actions to context menu.
To match the rename in the last commit.
The term "VariantEditor" referred to the initial approach of using QVariant for all properties. Now "PropertiesView" is more appropriate, since it is a view based on the type-agnostic "Property" hierarchy.
Now they both scale vertically to cover the minimum size of both.
Better to not touch the clipboard at all in this case.
When pasting custom properties, we now make sure that the Custom Properties group is expanded and select the pasted properties for some additional feedback. Also focus the first pasted property, which makes sure at least one of them is visible.
This change also disables Enter for opening the combo box popup, fixing the rather broken behavior (at least on Linux) that pressing Enter to select a type will immediately re-open the popup. That only applies to combo boxes in the Properties view, though.
This makes the property-specific actions like "Go to Object" and "Open Containing Folder" available again, as well as the Cut, Copy and Paste actions.
For now, the Custom Types Editor has no context menu anymore...
Property widgets are now removed before their property is deleted to avoid a crash when right-clicking the AddValueProperty, since that caused the focus to be lost and thus the removal of the property while at the same time triggering a context menu for it.
The QCommonStyle always uses the WindowText role when rendering a checkbox label, so change the palette so that is picks up the HighlightedText role when the property is selected.
The tab order follows the widget creation order, which is not what we want when properties are inserted between other properties. Hence we now explicitly set the tab order in this case.
We can't just call QWidget::setTabOrder on the row widgets unfortunately, because the call does nothing when called with widgets that have Qt::NoFocus policy.
Calling QWidget::setTabOrder only on the inserted sequence led to other issues, which led me to the solution of setting the tab order for all property widgets to match the order in the layout. To avoid too much repeated work when multiple properties are inserted, the fixTabOrder call is scheduled using QMetaObject::invokeMethod.
Instead of a using the disabled state for properties that are not set on the current object, inherited values now feature a Reset button and have their name displayed in bold when they have been overridden. This makes inherited properties directly editable, matching the behavior for class members.
To avoid confusion, properties from other selected objects are no longer displayed (this reverts 8cc0374).
This adds the feature originally implemented in 8434f5e to the new Properties view.
To make inherited properties easier to distinguish from explicitly set properties, their labels are now dimmed (by disabling them). This is done recursively for any class members.
To avoid synchronizing the value for all selected objects.
Now it is possible to enter the hex value (or CSS color name) to set a color's value.
4 tasks
This was referenced
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})