Feature/support numeric file sorting by ej-sanmartin · Pull Request #4284 · mapeditor/tiled (original) (raw)

added 2 commits

November 6, 2025 02:34

@ej-sanmartin

@ej-sanmartin

@bjorn bjorn changed the titleFeature/support numberic file sorting Feature/support numeric file sorting

Nov 6, 2025

@ej-sanmartin

@ej-sanmartin

@ej-sanmartin

@ej-sanmartin

The override was only called once in the constructor, where both mProjectModel and mProxyModel are already explicitly initialized. The defensive type-checking logic handled scenarios that never occur in practice. Removing it follows the standard Qt pattern of explicit model storage.

@ej-sanmartin

@ej-sanmartin

@ej-sanmartin

@ej-sanmartin

@bjorn

@bjorn

Introduced ProjectView::filePath since we need to get the path from a proxy index a lot.

Renamed ProjectView::model to ProjectView::projectModel to reduce chance of accidentally using the source model with proxy indices.

@bjorn

It probably fits slightly better there than in "Saving and Loading".

@bjorn

Seems to be provided by ProjectView::selectPath now.

@bjorn

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})