Removing a TODO comment in plotting.py by anbarief · Pull Request #504 · matplotlib/mplfinance (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

anbarief

Remove the comment

    # ----------------------------------------------------------------------
    # TODO:  Add some warnings, or raise an exception, if external_axes_mode
    #        and user is trying to figscale, figratio, or figsize.
    # ----------------------------------------------------------------------

Since this TODO has been done in line 408.

@anbarief

Remove the comment
# ---------------------------------------------------------------------- # TODO: Add some warnings, or raise an exception, if external_axes_mode # and user is trying to figscale, figratio, or figsize. # ----------------------------------------------------------------------

Since this TODO has been done in line 420.

@anbarief

@DanielGoldfarb

@anbarief
Arief- Thanks for contributing. --Daniel

Labels

released

code merged into repo AND released to Pypi

2 participants

@anbarief @DanielGoldfarb