Removed if (plottype not in _valid_types_all) ... and also num_panels = config['num_panels'] by anbarief · Pull Request #507 · matplotlib/mplfinance (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the documentation, Figure.show() "does not manage an GUI event loop. Consequently, the figure may only be shown briefly or not shown at all if you or your environment are not managing an event loop. If you're running a pure python shell or executing a non-GUI python script, you should use matplotlib.pyplot.show instead, which takes care of managing the event loop for you."

Therefore I am going to change this back to plt.show(). Otherwise all of the changes look fine and pass unit tests. Will be merging soon.