Added Syntax Highlighting for nftables-firewall config file by theredcmdcraft · Pull Request #3325 · micro-editor/micro (original) (raw)

No problem, it was my fault not testing it earlier at work were we've some good examples of nftable rules. It was still on my todo before it was merged. Ok, anyway...since this merge request is already merged we should create a new one to properly add the fixes into the nftables.yaml. I suggest to do the following (after the "upstream" is available in your private fork too):

git check nftables-improvements git fetch --all git reset HEAD~1 git stash git reset --hard upstream/master git stash apply git stash add runtime/syntax/nftables.yaml git commit -m "Added Suggested changes" git push --force-with-lease

Create from this resulting branch (nftables-improvements) in your fork a new pull request to to our upstream repository. Sure you can follow your own approach to create a new clean PR. Currently I've some doubts that the changed symbol and constant.string will work as expected.

Did i have to do these steps, when i synced my repo with this repo? I Synced the Fork, and then i created a new branch from the master branch, where i did the changes yesterday. Or can i simply create a new PR with my newly created branch as source. The Target is the micro master branch.