Merge micrometer-binder changes and revert micrometer-api changes by jonatan-ivanov · Pull Request #3046 · micrometer-metrics/micrometer (original) (raw)

and others added 8 commits

February 16, 2022 17:09

Allows data to be written to indexes or data streams.

Co-authored-by: Tommy Ludwig 8924140+shakuzen@users.noreply.github.com

This commit also updates the existing integration tests to use Elasticsearch 7.17.0.

Moving binders out

we have copied over the binders from core to a separate module called micrometer-binders binders in micrometer-core will be deprecated the migration path will be for the users to use the micrometer-binders jar together with micrometer-core if necessary

Added deprecations
Move binders out from the TCK too
Use io.micrometer.binder.jvm in JvmServiceLevelObjectives
Use io.micrometer.binder in the registries (Health and StatsD)
Use io.micrometer.binder in core
Use io.micrometer.binder in samples
Add deprecated note to javadoc with a suggestion to resolve it
Deleting javadoc comments from binder package-info I guess this was a c/p error.
Delete DiskSpaceMetrics that we deprecated earlier
Delete JettyStatisticsMetrics that we deprecated earlier
Delete KafkaConsumerMetrics that we deprecated earlier
Delete hibernate metrics that we deprecated earlier

Co-authored-by: Marcin Grzejszczak mgrzejszczak@vmware.com

Reverts the micrometer-api module in favor of the micrometer-binder module, merging changes from that.

[ sonatype-lift[bot] ](/apps/sonatype-lift)

Without this, tests fail on Apple silicon due to the missing compatible native library.

See gh-3048

The versions we were on used deprecated Gradle API and they logged warnings on Apple silicon. Both of these issues are resolved in these latest versions of the plugins.

See gh-3048 Resolves gh-3049

These were previously removed in the 2.0.x branch since they were deprecated in 1.x for a while already.

Core should contain the classes needed to write instrumentation, and binders should have instrumentation that we maintain. Therefore, the CacheMeterBinder and HTTP-related classes should remain in core. Related to fixing the cache stuff, this also moves the cache TCK implementations to micrometer-binders where the implementations of the cache binders are.

…#3043)

Moving binders out

Added deprecations
Move binders out from the TCK too
Use io.micrometer.binder.jvm in JvmServiceLevelObjectives
Use io.micrometer.binder in the registries (Health and StatsD)
Use io.micrometer.binder in core
Use io.micrometer.binder in samples
Add deprecated note to javadoc with a suggestion to resolve it
Deleting javadoc comments from binder package-info I guess this was a c/p error.
Delete DiskSpaceMetrics that we deprecated earlier
Delete JettyStatisticsMetrics that we deprecated earlier
Delete KafkaConsumerMetrics that we deprecated earlier
Delete hibernate metrics that we deprecated earlier

Co-authored-by: Marcin Grzejszczak mgrzejszczak@vmware.com

Without this, tests fail on Apple silicon due to the missing compatible native library.

See gh-3048

The versions we were on used deprecated Gradle API and they logged warnings on Apple silicon. Both of these issues are resolved in these latest versions of the plugins.

See gh-3048 Resolves gh-3049

shakuzen marked this pull request as ready for review

March 3, 2022 17:28

shakuzen changed the title~~Merge micrometer-binder changes with micrometer-api changes~~ Merge micrometer-binder changes and revert micrometer-api changes

Mar 15, 2022

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})