Update the PrometheusRSocketClientProperties prefix by onobc · Pull Request #77 · micrometer-metrics/prometheus-rsocket-proxy (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly one way or the other. As you say, we do have a micrometer-specific config prop prefix elsewhere, so part of me wants to align with that. On the other hand, I can understand how using the same naming scheme that Spring Boot uses would be familiar and perhaps expected from Spring Boot users and this config props is in a Spring Boot starter.

If we go with management. I would suggest management.prometheus-rsocket.metrics.export rather than using the same prefix (management.prometheus.metrics.export) as Spring Boot uses for its Prometheus integration in Actuator. It feels like we shouldn't be adding properties to something provided by an external project. Thoughts?