add format target to cmake by strega-nil-ms · Pull Request #2671 · microsoft/STL (original) (raw)

Looks great! I've verified the failure experiences in #2681 and #2682, and locally verified that CMake's printed messages are expected. The clang-format experience is a little different from the current one (have to click through to see the diff) but I'm ok with that behavioral change.

I went ahead and pushed a message clarification to create-prdiff.ps1 to help contributors seeing this output for the first time, and some changes to validate.cpp - minor style issues plus a rework of how any_errors are recorded to reduce verbosity and ensure that Code Format Validation will always fail if we print a failure message (this restores detection of long paths, paths with spaces, and the new bad extensions). I believe that this preserves your design intent but please meow if you disagree!