Delete <cvt/meow> by StephanTLavavej · Pull Request #4458 · microsoft/STL (original) (raw)

Fixes #282.

<cvt/meow> was deprecated by #3924 in VS 2022 17.8, so we'll have shipped two long-term-support releases (17.8 and 17.10) with that deprecation. @MahmoudGSaleh has confirmed that we can go ahead and remove these headers in 17.11. These headers were never documented.

In VS, this will delete 78 files, 4.8 MB, which is the major benefit that users will experience. For us, it reduces our test costs and maintenance surface area.

• Delete stl/inc/cvt (78 files, 5,061,936 bytes).
• stl/CMakeLists.txt: Drop all ${CMAKE_CURRENT_LIST_DIR}/inc/cvt/ lines.
• yvals_core.h: _DEPRECATE_STDEXT_CVT is now unused; replace it with a tombstone for STL4044.
• Delete tests/tr1/tests/cvt (76 files, 32,051 bytes).
• Delete tests/tr1/include/cvt_xtest.h (1 file, 4,990 bytes).
• tests/tr1/test.lst: Drop all tests\cvt\ lines.
• tests/std/tests: Delete Dev11_0453373_codecvt_compiles and VSO_0000000_instantiate_cvt (4 files, 7,866 bytes).
• tests/std/test.lst: Drop Dev11_0453373_codecvt_compiles and VSO_0000000_instantiate_cvt.
• P0218R1_filesystem: Drop/replace test coverage using stdext::cvt facets.
  • There are no replacements for stdext::cvt::codecvt_cp1251 and stdext::cvt::codecvt_sjis.
  • We can replace stdext::cvt::codecvt_utf8_utf16 with the deprecated std::codecvt_utf8_utf16.
  • This was the last use of _SILENCE_STDEXT_CVT_DEPRECATION_WARNING.

⚠️ Note to self: this will require a slightly larger-than-usual amount of MSVC-internal work to remove the cvt subdirectory from the build and setup authoring.