Update _MSVC_STL_UPDATE to June 2024 in yvals_core.h by Arup-Chauhan · Pull Request #4708 · microsoft/STL (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits2 Checks39 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes #4704

This pull request updates the _MSVC_STL_UPDATE macro value in yvals_core.h to the latest version. This change is intended to reflect the current state of the STL.

Hi, as per the requirements of the contributing to STL open source, I have made a PR request, please approve.

It intersects with already opened #4706.

It intersects with already opened #4706.

Hi I wanted to follow the "good-first-issue" methodology as mentioned by Stephan and contribute to STL open source and hence raised this PR.

Please guide me is there any other alternative, to avoid this intersection?

I mean your PR is a duplicate of the #4706 that was opened a bit earlier.

I mean your PR is a duplicate of the #4706 that was opened a bit earlier.

Yes, I did notice it, what should be my next steps?

Thanks! We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. As #4706 was created earlier, but wasn't initially linked to the issue it resolves, I believe you both deserve credit. I'll merge the earlier-created PR, but credit you as a co-author. I'll post a comment here when that happens.

Thanks! We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. As #4706 was created earlier, but wasn't initially linked to the issue it resolves, I believe you both deserve credit. I'll merge the earlier-created PR, but credit you as a co-author. I'll post a comment here when that happens.

Thank you @StephanTLavavej ! Looking forward for more contributions!

I've merged the earlier-created PR and credited you as a co-author for this identical change:

065a036

I'll also link your PR in the STL Changelog. Thanks again and congratulations on your first STL commit! 🎉 😸 🥳