: Alternate form general floating-point width handling by alexprabhat99 · Pull Request #5261 · microsoft/STL (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation19 Commits6 Checks39 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This comment was marked as resolved.
@microsoft-github-policy-service agree
Thank you, looks great! 😻
We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. Your PR will be part of the next batch, probably this week but maybe next week depending on how busy I am. (There's plenty of time to get fixes into 17.14 Preview 3.) I'll post comments here as I prepare your PR for merging.
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.
Thanks for fixing this runtime correctness bug in one of the STL's most popular new headers! 🐞 🛠️ 😻
By the way, it appears that your commits contained two email addresses, only one of which is known to GitHub, which causes your commit to appear to have a coauthor ("alexprabhat99 and alexprabhatbara"). You can fix this by telling GitHub about your alternate email address - I do this with my work and personal emails. Click on your profile avatar in the upper right > Settings > Emails (in the left sidebar), then add your secondary email address.
Labels
Something isn't working
C++20/23 format