Update _MSVC_STL_UPDATE to May 2025 and update _MSVC_STL_VERSION to 145 by vinay-852 · Pull Request #5464 · microsoft/STL (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This PR updates the _MSVC_STL_VERSION macro in yvals_core.h from 143 to 145 to reflect the beginning of work on Visual Studio 18, whose toolset will identify itself as "v145".

Updated line:
#define _MSVC_STL_VERSION 143 → #define _MSVC_STL_VERSION 145

#define _MSVC_STL_UPDATE 202504L→#define _MSVC_STL_UPDATE 202505L

This change ensures consistency with the new toolset versioning and aligns with the guidelines mentioned in issue #5461.

Closes #5461 .

Thanks! There's a typo in your PR description - it says it's changing _MSVC_STL_UPDATE from 202504L to 202504L, which is the same value. However, the actual code change is correct. (You can edit the PR's description to fix it. And in the future, if you need to fix a PR's code changes, you can push additional commits instead of closing the PR and opening a new one.)

We merge PRs simultaneously to our GitHub and MSVC-internal repos, mirrored in a semi-manual process and batched up to save time. Your PR will be part of the next batch, probably next week (depending on how busy I am). I'll post comments here as I prepare your PR for merging.

Thanks! There's a typo in your PR description - it says it's changing _MSVC_STL_UPDATE from 202504L to 202504L, which is the same value. However, the actual code change is correct. (You can edit the PR's description to fix it. And in the future, if you need to fix a PR's code changes, you can push additional commits instead of closing the PR and opening a new one.)

We merge PRs simultaneously to our GitHub and MSVC-internal repos, mirrored in a semi-manual process and batched up to save time. Your PR will be part of the next batch, probably next week (depending on how busy I am). I'll post comments here as I prepare your PR for merging.

Thanks for the clarification, Stephan! I’ll update the description and keep your suggestions in mind for future PRs.

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request

May 9, 2025

StephanTLavavej changed the titleUpdate _MSVC_STL_VERSION from 143 to 145 for Visual Studio 18 toolset Update _MSVC_STL_UPDATE to May 2025 and update _MSVC_STL_VERSION to 145

May 9, 2025

Thanks for updating these version macros and congratulations on your first microsoft/STL commit! 🎉 😻 🐈

Labels

2 participants