Unicode 16 by JMazurkiewicz · Pull Request #5571 · microsoft/STL (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits12 Checks39 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

• Implement generation of the Indic_Conjunct_Break table in the unicode_properties_data_gen.py script. We need this table to implement the new segmentation rule.
• Update __msvc_format_ucd_tables.hpp.
• Implement GB9c segmentation rule (added in Unicode 15.1) in _Grapheme_break_property_iterator.
• Update tests.

Previous PR: #3556

FWIW, this is also related to CWG-2843 which is recently accepted. No change requested - Unicode 16 is definitely OK as the resolution requires Unicode 15.1 as the minimum version.

…eak_property_iterator2`

This is gaining a new data member _GB9c_regex _GB9c_rx;.

…tring_prefix_iterator_utf2`

This contains _Grapheme_break_property_iterator2<_CharT> _WrappedIter;.

This is the final part. The alias _Measure_string_prefix_iterator can expand to this type, but aliases don't need to be renamed. The only use of that alias is within the function _Measure_string_prefix(), so renaming these two classes is sufficient to preserve ABI.

Thanks! 😻 And apologies for taking over 4 months to review this.

I pushed a conflict-free (albeit large) merge with main, a couple of nitpick commits, and a couple of class renames to preserve ABI.

I verified that the product and test code are exactly generated by the scripts (after clang-formatting).

This comment was marked as resolved.

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Can we get a PR for Unicode 17 soon as well please?

Thanks for this highly nontrivial PR! 🐱 🐈 🐈‍⬛

Labels