Guidance on writing declaration file for multi-targeted libraries · Issue #4337 · microsoft/TypeScript (original) (raw)

It is now possible for a library to hit every type of target that TypeScript supports (module, namespace, and ES6). Currently, writing a declaration file for a library like this can be very challenging. The default today is something like this:

declare namespace MyLib { export ... }

declare module 'mylib' { export = MyLib; }

This has a couple issues:

  1. If you're using this in the module sense, using this declaration file will result in TypeScript thinking there is a globally available variable MyLib which is not actually true. This can lead to runtime errors. (see Create "Global / External-agnostic" declaration files without exposing internal definitions #2018)
  2. If you're using ES6 import syntax TypeScript will consider this module to be in the CommonJS style and will not allow default imports even though the library actually supports them.

In the past, regarding item 1, it's been suggested that we split the declarations into two files (one for modules and one for namespaces). This makes sense. I think it also makes sense to extend that concept for ES6 modules. So if you have a library that targets all three, then you will have three mutually exclusive declaration files. Where things then become problematic is with duplicating the declarations in each file (which ideally should not happen). It is impossible to import an ambient module into an ambient namespace. It is possible to use an ambient namespace in an ambient module, but a naive approach to that (as shown in the common case above) violates item 1.

Therefore, I propose this guidance to writing these declaration files.

// mylib-common.d.ts

declare namespace __MyLib { export ... }

// mylib-namespace.d.ts

/// import MyLib = __MyLib;

// mylib-module.d.ts

/// declare module 'mylib' { export = __MyLib; }

// mylib-es6.d.ts

/// declare module 'mylib' { export * from __MyLib; // this doesn't currently work, see #4336 export default __MyLib; // if there is a default export }

Unfortunately this is currently hypothetical since you cannot re-export namespace declarations from an ES6 declaration.

I'm proposing this as a baseline for discussion to solve this issue for good. It's possible I'm going down the wrong track or that there is already a better way to handle these cases. It would also be great if we could get some buy-in from the TypeScript language to solve this, if needed.

Some possible ways TypeScript could be improved in this area:

  1. Fix Re-exporting namespace declarations in ES6 ambient declaration #4336
  2. Make it so that __MyLib only exists as a namespace and not as a value, either through convention (prefixed with __) or through additional syntax.

cc @johnnyreilly @vvakame