Assertions in control flow analysis by ahejlsberg · Pull Request #32695 · microsoft/TypeScript (original) (raw)
@ahejlsberg
The results of the perf run you requested are in!
Here they are:
Comparison Report - master..32695
| Metric | master | 32695 | Delta | Best | Worst |
|---|---|---|---|---|---|
| Angular - node (v12.1.0, x64) | |||||
| Memory used | 325,416k (± 0.03%) | 325,819k (± 0.02%) | +403k (+ 0.12%) | 325,735k | 326,007k |
| Parse Time | 1.44s (± 0.91%) | 1.43s (± 0.74%) | -0.01s (- 0.97%) | 1.41s | 1.45s |
| Bind Time | 0.76s (± 0.78%) | 0.77s (± 1.49%) | +0.00s (+ 0.52%) | 0.75s | 0.81s |
| Check Time | 4.22s (± 0.44%) | 4.27s (± 0.35%) | +0.04s (+ 1.07%) | 4.24s | 4.32s |
| Emit Time | 5.21s (± 0.49%) | 5.27s (± 0.82%) | +0.06s (+ 1.07%) | 5.21s | 5.39s |
| Total Time | 11.64s (± 0.33%) | 11.73s (± 0.48%) | +0.09s (+ 0.78%) | 11.65s | 11.90s |
| Monaco - node (v12.1.0, x64) | |||||
| Memory used | 345,830k (± 0.02%) | 346,156k (± 0.02%) | +326k (+ 0.09%) | 346,045k | 346,293k |
| Parse Time | 1.19s (± 0.64%) | 1.17s (± 0.48%) | -0.02s (- 1.52%) | 1.16s | 1.18s |
| Bind Time | 0.67s (± 0.33%) | 0.68s (± 0.54%) | +0.00s (+ 0.75%) | 0.67s | 0.68s |
| Check Time | 4.28s (± 0.44%) | 4.29s (± 0.35%) | +0.01s (+ 0.28%) | 4.26s | 4.32s |
| Emit Time | 2.84s (± 0.67%) | 2.85s (± 0.97%) | +0.00s (+ 0.18%) | 2.81s | 2.93s |
| Total Time | 8.97s (± 0.38%) | 8.98s (± 0.28%) | +0.01s (+ 0.09%) | 8.94s | 9.05s |
| TFS - node (v12.1.0, x64) | |||||
| Memory used | 301,335k (± 0.02%) | 301,644k (± 0.02%) | +310k (+ 0.10%) | 301,532k | 301,724k |
| Parse Time | 0.92s (± 0.84%) | 0.91s (± 0.92%) | -0.02s (- 1.74%) | 0.89s | 0.92s |
| Bind Time | 0.62s (± 1.08%) | 0.63s (± 0.80%) | +0.01s (+ 1.30%) | 0.61s | 0.63s |
| Check Time | 3.83s (± 0.46%) | 3.86s (± 0.54%) | +0.03s (+ 0.89%) | 3.79s | 3.89s |
| Emit Time | 2.94s (± 0.63%) | 2.96s (± 0.76%) | +0.02s (+ 0.75%) | 2.89s | 3.01s |
| Total Time | 8.30s (± 0.34%) | 8.34s (± 0.26%) | +0.05s (+ 0.57%) | 8.30s | 8.38s |
| Angular - node (v8.9.0, x64) | |||||
| Memory used | 343,931k (± 0.01%) | 344,376k (± 0.01%) | +445k (+ 0.13%) | 344,294k | 344,499k |
| Parse Time | 1.93s (± 0.34%) | 1.83s (± 0.36%) | -0.10s (- 5.12%) | 1.82s | 1.85s |
| Bind Time | 0.82s (± 0.57%) | 0.82s (± 0.91%) | -0.00s (- 0.37%) | 0.81s | 0.84s |
| Check Time | 5.07s (± 0.33%) | 5.10s (± 0.81%) | +0.03s (+ 0.61%) | 5.03s | 5.19s |
| Emit Time | 6.08s (± 0.57%) | 5.97s (± 1.60%) | -0.11s (- 1.88%) | 5.71s | 6.12s |
| Total Time | 13.90s (± 0.37%) | 13.72s (± 0.70%) | -0.18s (- 1.32%) | 13.48s | 13.86s |
| Monaco - node (v8.9.0, x64) | |||||
| Memory used | 363,317k (± 0.01%) | 363,607k (± 0.01%) | +290k (+ 0.08%) | 363,514k | 363,675k |
| Parse Time | 1.52s (± 0.45%) | 1.43s (± 0.31%) | -0.09s (- 6.10%) | 1.42s | 1.44s |
| Bind Time | 0.88s (± 0.39%) | 0.88s (± 1.68%) | +0.01s (+ 0.68%) | 0.86s | 0.92s |
| Check Time | 5.28s (± 0.35%) | 5.20s (± 1.37%) | -0.08s (- 1.46%) | 5.03s | 5.30s |
| Emit Time | 2.93s (± 0.37%) | 3.14s (± 6.26%) | +0.21s (+ 7.23%) | 2.91s | 3.49s |
| Total Time | 10.61s (± 0.14%) | 10.67s (± 1.38%) | +0.05s (+ 0.50%) | 10.49s | 10.96s |
| TFS - node (v8.9.0, x64) | |||||
| Memory used | 317,282k (± 0.02%) | 317,510k (± 0.01%) | +228k (+ 0.07%) | 317,443k | 317,563k |
| Parse Time | 1.23s (± 0.61%) | 1.13s (± 0.33%) | -0.10s (- 7.95%) | 1.13s | 1.14s |
| Bind Time | 0.66s (± 0.74%) | 0.67s (± 0.67%) | +0.00s (+ 0.60%) | 0.66s | 0.68s |
| Check Time | 4.47s (± 0.57%) | 4.49s (± 0.42%) | +0.02s (+ 0.54%) | 4.45s | 4.53s |
| Emit Time | 3.05s (± 0.66%) | 3.19s (± 1.73%) | +0.13s (+ 4.35%) | 3.05s | 3.26s |
| Total Time | 9.42s (± 0.33%) | 9.48s (± 0.55%) | +0.06s (+ 0.66%) | 9.36s | 9.58s |
| Angular - node (v8.9.0, x86) | |||||
| Memory used | 194,854k (± 0.02%) | 195,000k (± 0.02%) | +146k (+ 0.08%) | 194,928k | 195,056k |
| Parse Time | 1.87s (± 0.46%) | 1.78s (± 0.47%) | -0.09s (- 4.76%) | 1.76s | 1.80s |
| Bind Time | 0.95s (± 0.87%) | 0.96s (± 0.73%) | +0.01s (+ 0.52%) | 0.94s | 0.97s |
| Check Time | 4.59s (± 0.72%) | 4.65s (± 0.56%) | +0.07s (+ 1.46%) | 4.61s | 4.72s |
| Emit Time | 5.85s (± 0.87%) | 5.78s (± 0.83%) | -0.07s (- 1.20%) | 5.67s | 5.87s |
| Total Time | 13.26s (± 0.54%) | 13.17s (± 0.48%) | -0.09s (- 0.65%) | 13.03s | 13.33s |
| Monaco - node (v8.9.0, x86) | |||||
| Memory used | 202,921k (± 0.01%) | 203,068k (± 0.03%) | +147k (+ 0.07%) | 202,941k | 203,192k |
| Parse Time | 1.59s (± 0.56%) | 1.48s (± 0.56%) | -0.10s (- 6.37%) | 1.47s | 1.50s |
| Bind Time | 0.70s (± 0.52%) | 0.71s (± 0.56%) | +0.01s (+ 0.99%) | 0.70s | 0.72s |
| Check Time | 4.90s (± 0.44%) | 4.90s (± 0.74%) | +0.00s (+ 0.02%) | 4.79s | 4.96s |
| Emit Time | 3.19s (± 0.76%) | 3.18s (± 0.97%) | -0.01s (- 0.38%) | 3.13s | 3.25s |
| Total Time | 10.38s (± 0.30%) | 10.28s (± 0.45%) | -0.11s (- 1.02%) | 10.14s | 10.37s |
| TFS - node (v8.9.0, x86) | |||||
| Memory used | 178,237k (± 0.02%) | 178,315k (± 0.02%) | +78k (+ 0.04%) | 178,185k | 178,389k |
| Parse Time | 1.30s (± 0.65%) | 1.19s (± 0.93%) | -0.11s (- 8.22%) | 1.17s | 1.23s |
| Bind Time | 0.62s (± 1.42%) | 0.64s (± 1.20%) | +0.01s (+ 1.93%) | 0.63s | 0.66s |
| Check Time | 4.28s (± 0.70%) | 4.34s (± 0.92%) | +0.06s (+ 1.28%) | 4.27s | 4.41s |
| Emit Time | 2.88s (± 0.45%) | 2.84s (± 2.22%) | -0.04s (- 1.35%) | 2.64s | 2.93s |
| Total Time | 9.09s (± 0.41%) | 9.01s (± 0.81%) | -0.08s (- 0.90%) | 8.84s | 9.16s |
| Angular - node (v9.0.0, x64) | |||||
| Memory used | 343,623k (± 0.01%) | 343,948k (± 0.02%) | +325k (+ 0.09%) | 343,706k | 344,059k |
| Parse Time | 1.68s (± 0.49%) | 1.67s (± 0.44%) | -0.01s (- 0.42%) | 1.66s | 1.69s |
| Bind Time | 0.77s (± 0.84%) | 0.77s (± 0.68%) | +0.00s (+ 0.13%) | 0.76s | 0.78s |
| Check Time | 4.78s (± 0.51%) | 4.83s (± 0.57%) | +0.05s (+ 0.98%) | 4.78s | 4.91s |
| Emit Time | 5.69s (± 1.81%) | 5.48s (± 0.98%) | -0.22s (- 3.85%) | 5.37s | 5.61s |
| Total Time | 12.92s (± 0.87%) | 12.74s (± 0.30%) | -0.18s (- 1.37%) | 12.68s | 12.84s |
| Monaco - node (v9.0.0, x64) | |||||
| Memory used | 363,060k (± 0.03%) | 363,350k (± 0.03%) | +290k (+ 0.08%) | 363,188k | 363,663k |
| Parse Time | 1.29s (± 0.90%) | 1.27s (± 0.52%) | -0.02s (- 1.24%) | 1.26s | 1.28s |
| Bind Time | 0.85s (± 0.58%) | 0.86s (± 0.88%) | +0.00s (+ 0.23%) | 0.84s | 0.88s |
| Check Time | 4.91s (± 0.45%) | 4.91s (± 0.50%) | -0.00s (- 0.02%) | 4.85s | 4.94s |
| Emit Time | 3.36s (± 0.43%) | 3.37s (± 0.34%) | +0.00s (+ 0.12%) | 3.35s | 3.40s |
| Total Time | 10.41s (± 0.36%) | 10.40s (± 0.37%) | -0.01s (- 0.09%) | 10.32s | 10.50s |
| TFS - node (v9.0.0, x64) | |||||
| Memory used | 317,006k (± 0.02%) | 317,300k (± 0.02%) | +293k (+ 0.09%) | 317,182k | 317,415k |
| Parse Time | 1.02s (± 0.51%) | 1.01s (± 0.47%) | -0.01s (- 1.08%) | 1.00s | 1.02s |
| Bind Time | 0.61s (± 0.97%) | 0.61s (± 0.97%) | +0.00s (+ 0.16%) | 0.60s | 0.63s |
| Check Time | 4.34s (± 0.47%) | 4.39s (± 0.33%) | +0.05s (+ 1.13%) | 4.35s | 4.42s |
| Emit Time | 3.20s (± 0.62%) | 3.18s (± 0.48%) | -0.01s (- 0.44%) | 3.15s | 3.21s |
| Total Time | 9.18s (± 0.33%) | 9.20s (± 0.27%) | +0.02s (+ 0.20%) | 9.14s | 9.25s |
| Angular - node (v9.0.0, x86) | |||||
| Memory used | 194,883k (± 0.02%) | 195,048k (± 0.04%) | +165k (+ 0.08%) | 194,887k | 195,228k |
| Parse Time | 1.60s (± 0.55%) | 1.59s (± 0.37%) | -0.01s (- 0.88%) | 1.58s | 1.60s |
| Bind Time | 0.88s (± 0.53%) | 0.89s (± 1.07%) | +0.01s (+ 0.68%) | 0.87s | 0.91s |
| Check Time | 4.30s (± 0.69%) | 4.34s (± 0.75%) | +0.04s (+ 0.91%) | 4.29s | 4.45s |
| Emit Time | 5.53s (± 0.99%) | 5.54s (± 0.71%) | +0.01s (+ 0.22%) | 5.47s | 5.65s |
| Total Time | 12.31s (± 0.59%) | 12.35s (± 0.46%) | +0.04s (+ 0.37%) | 12.26s | 12.47s |
| Monaco - node (v9.0.0, x86) | |||||
| Memory used | 202,929k (± 0.02%) | 203,055k (± 0.03%) | +126k (+ 0.06%) | 202,917k | 203,166k |
| Parse Time | 1.32s (± 0.85%) | 1.31s (± 0.67%) | -0.01s (- 0.45%) | 1.30s | 1.34s |
| Bind Time | 0.64s (± 0.62%) | 0.65s (± 0.58%) | +0.00s (+ 0.62%) | 0.64s | 0.65s |
| Check Time | 4.70s (± 0.56%) | 4.73s (± 0.71%) | +0.03s (+ 0.68%) | 4.67s | 4.83s |
| Emit Time | 3.09s (± 0.28%) | 3.09s (± 0.56%) | -0.00s (- 0.03%) | 3.04s | 3.12s |
| Total Time | 9.75s (± 0.32%) | 9.78s (± 0.42%) | +0.03s (+ 0.28%) | 9.70s | 9.88s |
| TFS - node (v9.0.0, x86) | |||||
| Memory used | 178,233k (± 0.01%) | 178,312k (± 0.03%) | +79k (+ 0.04%) | 178,185k | 178,407k |
| Parse Time | 1.04s (± 0.72%) | 1.03s (± 0.48%) | -0.01s (- 1.06%) | 1.01s | 1.03s |
| Bind Time | 0.57s (± 1.19%) | 0.57s (± 1.19%) | +0.00s (+ 0.17%) | 0.56s | 0.59s |
| Check Time | 4.12s (± 0.51%) | 4.14s (± 0.60%) | +0.02s (+ 0.39%) | 4.08s | 4.19s |
| Emit Time | 2.79s (± 1.18%) | 2.78s (± 1.13%) | -0.01s (- 0.43%) | 2.73s | 2.88s |
| Total Time | 8.53s (± 0.53%) | 8.52s (± 0.50%) | -0.00s (- 0.06%) | 8.44s | 8.63s |
System
| Machine Name | ts-ci-ubuntu |
|---|---|
| Platform | linux 4.4.0-142-generic |
| Architecture | x64 |
| Available Memory | 16 GB |
| Available Memory | 1 GB |
| CPUs | 4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz |
Hosts
- node (v12.1.0, x64)
- node (v8.9.0, x64)
- node (v8.9.0, x86)
- node (v9.0.0, x64)
- node (v9.0.0, x86)
Scenarios
- Angular - node (v12.1.0, x64)
- Angular - node (v8.9.0, x64)
- Angular - node (v8.9.0, x86)
- Angular - node (v9.0.0, x64)
- Angular - node (v9.0.0, x86)
- Monaco - node (v12.1.0, x64)
- Monaco - node (v8.9.0, x64)
- Monaco - node (v8.9.0, x86)
- Monaco - node (v9.0.0, x64)
- Monaco - node (v9.0.0, x86)
- TFS - node (v12.1.0, x64)
- TFS - node (v8.9.0, x64)
- TFS - node (v8.9.0, x86)
- TFS - node (v9.0.0, x64)
- TFS - node (v9.0.0, x86)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | 32695 | 10 |
| Baseline | master | 10 |