Recursive type references by ahejlsberg · Pull Request #33050 · microsoft/TypeScript (original) (raw)
@ahejlsberg
The results of the perf run you requested are in!
Here they are:
Comparison Report - master..33050
| Metric | master | 33050 | Delta | Best | Worst |
|---|---|---|---|---|---|
| Angular - node (v12.1.0, x64) | |||||
| Memory used | 325,602k (± 0.02%) | 359,124k (± 0.04%) | +33,523k (+10.30%) | 358,591k | 359,283k |
| Parse Time | 1.48s (± 0.66%) | 1.47s (± 0.63%) | -0.01s (- 0.67%) | 1.45s | 1.49s |
| Bind Time | 0.76s (± 0.89%) | 0.76s (± 0.59%) | -0.01s (- 0.79%) | 0.75s | 0.77s |
| Check Time | 4.21s (± 0.47%) | 4.39s (± 0.35%) | +0.18s (+ 4.20%) | 4.36s | 4.43s |
| Emit Time | 5.30s (± 1.06%) | 5.26s (± 0.76%) | -0.04s (- 0.77%) | 5.18s | 5.36s |
| Total Time | 11.75s (± 0.61%) | 11.87s (± 0.40%) | +0.12s (+ 1.02%) | 11.78s | 12.00s |
| Monaco - node (v12.1.0, x64) | |||||
| Memory used | 345,852k (± 0.03%) | 360,491k (± 0.02%) | +14,640k (+ 4.23%) | 360,365k | 360,727k |
| Parse Time | 1.23s (± 0.63%) | 1.23s (± 0.73%) | -0.00s (- 0.41%) | 1.20s | 1.24s |
| Bind Time | 0.68s (± 1.17%) | 0.68s (± 0.85%) | -0.00s (- 0.29%) | 0.67s | 0.69s |
| Check Time | 4.27s (± 0.47%) | 4.36s (± 0.57%) | +0.09s (+ 2.11%) | 4.29s | 4.40s |
| Emit Time | 2.85s (± 0.55%) | 2.86s (± 1.02%) | +0.00s (+ 0.07%) | 2.80s | 2.95s |
| Total Time | 9.04s (± 0.31%) | 9.12s (± 0.48%) | +0.08s (+ 0.93%) | 9.02s | 9.24s |
| TFS - node (v12.1.0, x64) | |||||
| Memory used | 301,389k (± 0.02%) | 307,834k (± 0.01%) | +6,446k (+ 2.14%) | 307,753k | 307,969k |
| Parse Time | 0.95s (± 0.62%) | 0.95s (± 0.74%) | -0.00s (- 0.31%) | 0.94s | 0.97s |
| Bind Time | 0.62s (± 0.79%) | 0.62s (± 1.04%) | -0.00s (- 0.32%) | 0.61s | 0.64s |
| Check Time | 3.85s (± 0.66%) | 3.92s (± 0.55%) | +0.07s (+ 1.82%) | 3.85s | 3.96s |
| Emit Time | 2.95s (± 0.36%) | 2.99s (± 1.06%) | +0.04s (+ 1.49%) | 2.93s | 3.05s |
| Total Time | 8.37s (± 0.41%) | 8.48s (± 0.51%) | +0.11s (+ 1.30%) | 8.39s | 8.57s |
| Angular - node (v8.9.0, x64) | |||||
| Memory used | 344,224k (± 0.02%) | 378,076k (± 0.01%) | +33,852k (+ 9.83%) | 377,963k | 378,173k |
| Parse Time | 1.98s (± 0.44%) | 2.00s (± 0.88%) | +0.02s (+ 0.81%) | 1.97s | 2.04s |
| Bind Time | 0.82s (± 0.98%) | 0.82s (± 1.06%) | 0.00s ( 0.00%) | 0.80s | 0.84s |
| Check Time | 5.01s (± 0.52%) | 5.38s (± 0.43%) | +0.37s (+ 7.41%) | 5.33s | 5.44s |
| Emit Time | 6.11s (± 0.53%) | 6.37s (± 1.51%) | +0.26s (+ 4.22%) | 6.17s | 6.61s |
| Total Time | 13.91s (± 0.33%) | 14.56s (± 0.79%) | +0.65s (+ 4.65%) | 14.36s | 14.89s |
| Monaco - node (v8.9.0, x64) | |||||
| Memory used | 363,679k (± 0.02%) | 378,332k (± 0.01%) | +14,653k (+ 4.03%) | 378,242k | 378,441k |
| Parse Time | 1.56s (± 0.48%) | 1.56s (± 0.32%) | -0.01s (- 0.32%) | 1.54s | 1.56s |
| Bind Time | 0.89s (± 0.93%) | 0.88s (± 0.93%) | -0.00s (- 0.34%) | 0.87s | 0.91s |
| Check Time | 5.15s (± 1.40%) | 5.41s (± 0.79%) | +0.25s (+ 4.87%) | 5.32s | 5.47s |
| Emit Time | 3.15s (± 4.30%) | 2.98s (± 1.01%) | -0.16s (- 5.24%) | 2.91s | 3.06s |
| Total Time | 10.75s (± 0.86%) | 10.82s (± 0.43%) | +0.08s (+ 0.71%) | 10.74s | 10.95s |
| TFS - node (v8.9.0, x64) | |||||
| Memory used | 317,623k (± 0.02%) | 324,123k (± 0.01%) | +6,500k (+ 2.05%) | 324,046k | 324,178k |
| Parse Time | 1.26s (± 0.75%) | 1.26s (± 0.58%) | +0.00s (+ 0.08%) | 1.24s | 1.27s |
| Bind Time | 0.71s (± 5.63%) | 0.69s (± 5.55%) | -0.02s (- 2.81%) | 0.66s | 0.80s |
| Check Time | 4.41s (± 1.44%) | 4.49s (± 1.11%) | +0.08s (+ 1.84%) | 4.33s | 4.55s |
| Emit Time | 3.05s (± 0.97%) | 3.08s (± 0.55%) | +0.03s (+ 0.88%) | 3.02s | 3.11s |
| Total Time | 9.43s (± 0.39%) | 9.52s (± 0.40%) | +0.09s (+ 0.92%) | 9.41s | 9.58s |
| Angular - node (v8.9.0, x86) | |||||
| Memory used | 194,997k (± 0.03%) | 211,984k (± 0.01%) | +16,987k (+ 8.71%) | 211,929k | 212,017k |
| Parse Time | 1.93s (± 0.65%) | 1.93s (± 0.99%) | +0.00s (+ 0.05%) | 1.90s | 1.99s |
| Bind Time | 0.95s (± 0.87%) | 0.94s (± 1.07%) | -0.01s (- 1.15%) | 0.93s | 0.98s |
| Check Time | 4.60s (± 0.60%) | 4.91s (± 0.73%) | +0.31s (+ 6.72%) | 4.81s | 4.98s |
| Emit Time | 5.83s (± 0.56%) | 6.14s (± 2.24%) | +0.30s (+ 5.23%) | 5.83s | 6.45s |
| Total Time | 13.31s (± 0.40%) | 13.92s (± 1.32%) | +0.61s (+ 4.54%) | 13.47s | 14.28s |
| Monaco - node (v8.9.0, x86) | |||||
| Memory used | 203,157k (± 0.02%) | 210,526k (± 0.02%) | +7,368k (+ 3.63%) | 210,418k | 210,624k |
| Parse Time | 1.62s (± 0.98%) | 1.61s (± 0.58%) | -0.01s (- 0.37%) | 1.59s | 1.63s |
| Bind Time | 0.72s (± 0.86%) | 0.72s (± 0.55%) | 0.00s ( 0.00%) | 0.71s | 0.73s |
| Check Time | 4.88s (± 0.66%) | 5.05s (± 0.69%) | +0.17s (+ 3.40%) | 4.99s | 5.15s |
| Emit Time | 3.20s (± 0.82%) | 3.23s (± 0.72%) | +0.03s (+ 0.81%) | 3.19s | 3.29s |
| Total Time | 10.43s (± 0.55%) | 10.60s (± 0.38%) | +0.18s (+ 1.71%) | 10.49s | 10.71s |
| TFS - node (v8.9.0, x86) | |||||
| Memory used | 178,520k (± 0.02%) | 181,759k (± 0.02%) | +3,239k (+ 1.81%) | 181,683k | 181,827k |
| Parse Time | 1.32s (± 0.79%) | 1.31s (± 0.94%) | -0.01s (- 0.46%) | 1.29s | 1.34s |
| Bind Time | 0.64s (± 1.97%) | 0.64s (± 1.32%) | 0.00s ( 0.00%) | 0.63s | 0.67s |
| Check Time | 4.31s (± 0.44%) | 4.34s (± 0.47%) | +0.04s (+ 0.81%) | 4.32s | 4.40s |
| Emit Time | 2.87s (± 0.98%) | 2.89s (± 2.01%) | +0.02s (+ 0.73%) | 2.77s | 3.03s |
| Total Time | 9.14s (± 0.56%) | 9.19s (± 0.79%) | +0.05s (+ 0.57%) | 9.01s | 9.34s |
| Angular - node (v9.0.0, x64) | |||||
| Memory used | 343,821k (± 0.02%) | 377,603k (± 0.01%) | +33,782k (+ 9.83%) | 377,520k | 377,693k |
| Parse Time | 1.72s (± 0.42%) | 1.71s (± 0.76%) | -0.01s (- 0.41%) | 1.70s | 1.76s |
| Bind Time | 0.76s (± 0.48%) | 0.76s (± 0.88%) | -0.00s (- 0.13%) | 0.75s | 0.78s |
| Check Time | 4.80s (± 0.41%) | 5.09s (± 0.84%) | +0.30s (+ 6.17%) | 4.99s | 5.18s |
| Emit Time | 5.67s (± 1.75%) | 6.02s (± 1.18%) | +0.35s (+ 6.11%) | 5.79s | 6.17s |
| Total Time | 12.96s (± 0.77%) | 13.59s (± 0.56%) | +0.63s (+ 4.87%) | 13.47s | 13.75s |
| Monaco - node (v9.0.0, x64) | |||||
| Memory used | 363,410k (± 0.03%) | 378,075k (± 0.01%) | +14,665k (+ 4.04%) | 377,979k | 378,196k |
| Parse Time | 1.32s (± 0.46%) | 1.31s (± 0.67%) | -0.00s (- 0.15%) | 1.30s | 1.34s |
| Bind Time | 0.84s (± 0.86%) | 0.84s (± 1.60%) | -0.01s (- 0.71%) | 0.81s | 0.86s |
| Check Time | 4.99s (± 1.69%) | 5.09s (± 1.29%) | +0.10s (+ 1.94%) | 4.95s | 5.22s |
| Emit Time | 3.21s (± 5.27%) | 3.18s (± 4.62%) | -0.03s (- 0.81%) | 2.91s | 3.36s |
| Total Time | 10.36s (± 0.98%) | 10.42s (± 1.03%) | +0.06s (+ 0.56%) | 10.20s | 10.65s |
| TFS - node (v9.0.0, x64) | |||||
| Memory used | 317,383k (± 0.01%) | 323,904k (± 0.01%) | +6,520k (+ 2.05%) | 323,838k | 323,979k |
| Parse Time | 1.04s (± 0.53%) | 1.04s (± 0.66%) | -0.01s (- 0.58%) | 1.02s | 1.05s |
| Bind Time | 0.62s (± 1.00%) | 0.62s (± 0.64%) | +0.00s (+ 0.32%) | 0.61s | 0.63s |
| Check Time | 4.39s (± 0.57%) | 4.44s (± 0.55%) | +0.06s (+ 1.30%) | 4.38s | 4.49s |
| Emit Time | 3.17s (± 0.72%) | 3.19s (± 1.02%) | +0.02s (+ 0.73%) | 3.09s | 3.23s |
| Total Time | 9.21s (± 0.43%) | 9.29s (± 0.43%) | +0.08s (+ 0.87%) | 9.19s | 9.38s |
| Angular - node (v9.0.0, x86) | |||||
| Memory used | 195,115k (± 0.04%) | 212,005k (± 0.04%) | +16,891k (+ 8.66%) | 211,741k | 212,124k |
| Parse Time | 1.64s (± 0.43%) | 1.64s (± 0.74%) | -0.00s (- 0.18%) | 1.61s | 1.66s |
| Bind Time | 0.90s (± 1.10%) | 0.89s (± 0.90%) | -0.01s (- 0.67%) | 0.87s | 0.91s |
| Check Time | 4.24s (± 0.27%) | 4.51s (± 0.67%) | +0.27s (+ 6.32%) | 4.45s | 4.60s |
| Emit Time | 5.52s (± 1.03%) | 5.61s (± 0.59%) | +0.09s (+ 1.65%) | 5.54s | 5.68s |
| Total Time | 12.30s (± 0.54%) | 12.65s (± 0.50%) | +0.35s (+ 2.84%) | 12.56s | 12.83s |
| Monaco - node (v9.0.0, x86) | |||||
| Memory used | 203,236k (± 0.02%) | 210,581k (± 0.02%) | +7,345k (+ 3.61%) | 210,496k | 210,650k |
| Parse Time | 1.35s (± 0.64%) | 1.34s (± 0.45%) | -0.00s (- 0.22%) | 1.33s | 1.36s |
| Bind Time | 0.65s (± 0.92%) | 0.65s (± 1.28%) | -0.00s (- 0.00%) | 0.63s | 0.66s |
| Check Time | 4.70s (± 1.00%) | 4.81s (± 0.33%) | +0.11s (+ 2.45%) | 4.78s | 4.86s |
| Emit Time | 3.08s (± 1.25%) | 3.13s (± 0.66%) | +0.04s (+ 1.43%) | 3.07s | 3.18s |
| Total Time | 9.77s (± 0.39%) | 9.93s (± 0.31%) | +0.16s (+ 1.63%) | 9.87s | 10.01s |
| TFS - node (v9.0.0, x86) | |||||
| Memory used | 178,591k (± 0.02%) | 181,779k (± 0.02%) | +3,188k (+ 1.78%) | 181,677k | 181,856k |
| Parse Time | 1.07s (± 0.66%) | 1.07s (± 1.25%) | -0.00s (- 0.28%) | 1.04s | 1.10s |
| Bind Time | 0.58s (± 0.95%) | 0.58s (± 0.89%) | -0.00s (- 0.17%) | 0.57s | 0.60s |
| Check Time | 4.16s (± 0.71%) | 4.18s (± 0.57%) | +0.02s (+ 0.58%) | 4.13s | 4.23s |
| Emit Time | 2.81s (± 1.28%) | 2.79s (± 1.13%) | -0.02s (- 0.71%) | 2.71s | 2.87s |
| Total Time | 8.62s (± 0.67%) | 8.62s (± 0.47%) | -0.00s (- 0.01%) | 8.56s | 8.74s |
System
| Machine Name | ts-ci-ubuntu |
|---|---|
| Platform | linux 4.4.0-142-generic |
| Architecture | x64 |
| Available Memory | 16 GB |
| Available Memory | 1 GB |
| CPUs | 4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz |
Hosts
- node (v12.1.0, x64)
- node (v8.9.0, x64)
- node (v8.9.0, x86)
- node (v9.0.0, x64)
- node (v9.0.0, x86)
Scenarios
- Angular - node (v12.1.0, x64)
- Angular - node (v8.9.0, x64)
- Angular - node (v8.9.0, x86)
- Angular - node (v9.0.0, x64)
- Angular - node (v9.0.0, x86)
- Monaco - node (v12.1.0, x64)
- Monaco - node (v8.9.0, x64)
- Monaco - node (v8.9.0, x86)
- Monaco - node (v9.0.0, x64)
- Monaco - node (v9.0.0, x86)
- TFS - node (v12.1.0, x64)
- TFS - node (v8.9.0, x64)
- TFS - node (v8.9.0, x86)
- TFS - node (v9.0.0, x64)
- TFS - node (v9.0.0, x86)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | 33050 | 10 |
| Baseline | master | 10 |