Add support for Optional Chaining by rbuckton · Pull Request #33294 · microsoft/TypeScript (original) (raw)
@rbuckton
The results of the perf run you requested are in!
Here they are:
Comparison Report - master..33294
| Metric | master | 33294 | Delta | Best | Worst |
|---|---|---|---|---|---|
| Angular - node (v12.1.0, x64) | |||||
| Memory used | 331,498k (± 0.02%) | 332,910k (± 0.05%) | +1,412k (+ 0.43%) | 332,347k | 333,118k |
| Parse Time | 1.56s (± 0.61%) | 1.57s (± 0.48%) | +0.01s (+ 0.58%) | 1.56s | 1.59s |
| Bind Time | 0.80s (± 0.62%) | 0.84s (± 0.66%) | +0.03s (+ 4.10%) | 0.83s | 0.85s |
| Check Time | 4.34s (± 0.28%) | 4.45s (± 0.60%) | +0.11s (+ 2.58%) | 4.40s | 4.52s |
| Emit Time | 5.25s (± 0.70%) | 5.47s (± 0.92%) | +0.22s (+ 4.27%) | 5.39s | 5.59s |
| Total Time | 11.95s (± 0.36%) | 12.33s (± 0.57%) | +0.38s (+ 3.18%) | 12.20s | 12.48s |
| Monaco - node (v12.1.0, x64) | |||||
| Memory used | 346,484k (± 0.01%) | 348,075k (± 0.02%) | +1,592k (+ 0.46%) | 347,970k | 348,244k |
| Parse Time | 1.23s (± 0.76%) | 1.23s (± 0.56%) | -0.00s (- 0.33%) | 1.21s | 1.24s |
| Bind Time | 0.70s (± 0.63%) | 0.72s (± 0.72%) | +0.02s (+ 2.71%) | 0.71s | 0.73s |
| Check Time | 4.40s (± 0.43%) | 4.43s (± 0.34%) | +0.03s (+ 0.68%) | 4.39s | 4.46s |
| Emit Time | 2.88s (± 0.75%) | 2.99s (± 0.54%) | +0.11s (+ 3.93%) | 2.94s | 3.02s |
| Total Time | 9.21s (± 0.39%) | 9.37s (± 0.24%) | +0.16s (+ 1.73%) | 9.31s | 9.42s |
| TFS - node (v12.1.0, x64) | |||||
| Memory used | 304,629k (± 0.02%) | 306,800k (± 0.02%) | +2,171k (+ 0.71%) | 306,693k | 306,902k |
| Parse Time | 0.95s (± 0.63%) | 0.96s (± 0.79%) | +0.00s (+ 0.10%) | 0.94s | 0.97s |
| Bind Time | 0.66s (± 0.68%) | 0.69s (± 0.83%) | +0.03s (+ 4.86%) | 0.68s | 0.71s |
| Check Time | 3.97s (± 0.64%) | 4.01s (± 0.55%) | +0.04s (+ 1.08%) | 3.98s | 4.07s |
| Emit Time | 2.97s (± 0.55%) | 3.11s (± 1.10%) | +0.14s (+ 4.61%) | 3.04s | 3.21s |
| Total Time | 8.55s (± 0.33%) | 8.77s (± 0.50%) | +0.22s (+ 2.54%) | 8.66s | 8.87s |
| Angular - node (v8.9.0, x64) | |||||
| Memory used | 350,502k (± 0.01%) | 352,094k (± 0.02%) | +1,592k (+ 0.45%) | 351,853k | 352,241k |
| Parse Time | 2.11s (± 0.42%) | 2.10s (± 0.53%) | -0.01s (- 0.57%) | 2.07s | 2.12s |
| Bind Time | 0.87s (± 0.77%) | 0.90s (± 0.83%) | +0.03s (+ 3.09%) | 0.89s | 0.92s |
| Check Time | 5.19s (± 0.47%) | 5.31s (± 0.58%) | +0.13s (+ 2.41%) | 5.25s | 5.40s |
| Emit Time | 5.95s (± 1.41%) | 6.27s (± 1.00%) | +0.32s (+ 5.42%) | 6.13s | 6.46s |
| Total Time | 14.12s (± 0.67%) | 14.58s (± 0.55%) | +0.46s (+ 3.24%) | 14.48s | 14.87s |
| Monaco - node (v8.9.0, x64) | |||||
| Memory used | 364,301k (± 0.01%) | 366,035k (± 0.01%) | +1,735k (+ 0.48%) | 365,931k | 366,151k |
| Parse Time | 1.56s (± 0.47%) | 1.57s (± 0.48%) | +0.01s (+ 0.83%) | 1.56s | 1.59s |
| Bind Time | 0.90s (± 0.68%) | 0.92s (± 0.32%) | +0.02s (+ 1.89%) | 0.91s | 0.92s |
| Check Time | 5.23s (± 1.03%) | 5.47s (± 0.45%) | +0.24s (+ 4.63%) | 5.42s | 5.54s |
| Emit Time | 3.28s (± 2.45%) | 3.06s (± 0.57%) | -0.22s (- 6.65%) | 3.02s | 3.10s |
| Total Time | 10.97s (± 0.37%) | 11.02s (± 0.34%) | +0.05s (+ 0.47%) | 10.97s | 11.13s |
| TFS - node (v8.9.0, x64) | |||||
| Memory used | 321,047k (± 0.01%) | 323,267k (± 0.01%) | +2,220k (+ 0.69%) | 323,199k | 323,327k |
| Parse Time | 1.27s (± 0.71%) | 1.27s (± 0.64%) | +0.01s (+ 0.63%) | 1.26s | 1.29s |
| Bind Time | 0.78s (± 6.89%) | 0.75s (± 1.04%) | -0.03s (- 3.97%) | 0.73s | 0.76s |
| Check Time | 4.52s (± 1.93%) | 4.67s (± 0.51%) | +0.15s (+ 3.37%) | 4.63s | 4.74s |
| Emit Time | 3.08s (± 0.73%) | 3.22s (± 0.49%) | +0.14s (+ 4.41%) | 3.18s | 3.25s |
| Total Time | 9.64s (± 0.56%) | 9.91s (± 0.35%) | +0.26s (+ 2.74%) | 9.84s | 9.99s |
| Angular - node (v8.9.0, x86) | |||||
| Memory used | 198,645k (± 0.02%) | 199,514k (± 0.03%) | +869k (+ 0.44%) | 199,363k | 199,648k |
| Parse Time | 2.04s (± 0.61%) | 2.04s (± 0.57%) | +0.01s (+ 0.44%) | 2.02s | 2.08s |
| Bind Time | 0.99s (± 1.01%) | 1.04s (± 1.02%) | +0.05s (+ 5.07%) | 1.02s | 1.07s |
| Check Time | 4.72s (± 0.35%) | 4.83s (± 0.41%) | +0.12s (+ 2.46%) | 4.79s | 4.87s |
| Emit Time | 5.78s (± 1.35%) | 6.05s (± 1.36%) | +0.27s (+ 4.71%) | 5.95s | 6.37s |
| Total Time | 13.52s (± 0.61%) | 13.96s (± 0.62%) | +0.45s (+ 3.29%) | 13.88s | 14.30s |
| Monaco - node (v8.9.0, x86) | |||||
| Memory used | 203,827k (± 0.02%) | 204,774k (± 0.02%) | +947k (+ 0.46%) | 204,680k | 204,861k |
| Parse Time | 1.62s (± 0.54%) | 1.60s (± 0.36%) | -0.02s (- 1.11%) | 1.59s | 1.61s |
| Bind Time | 0.72s (± 0.68%) | 0.76s (± 0.45%) | +0.04s (+ 5.39%) | 0.76s | 0.77s |
| Check Time | 5.32s (± 1.07%) | 5.34s (± 0.47%) | +0.02s (+ 0.43%) | 5.29s | 5.39s |
| Emit Time | 2.81s (± 2.88%) | 2.87s (± 0.44%) | +0.06s (+ 2.10%) | 2.85s | 2.91s |
| Total Time | 10.47s (± 0.47%) | 10.57s (± 0.27%) | +0.10s (+ 0.98%) | 10.52s | 10.65s |
| TFS - node (v8.9.0, x86) | |||||
| Memory used | 180,612k (± 0.01%) | 181,832k (± 0.01%) | +1,220k (+ 0.68%) | 181,787k | 181,890k |
| Parse Time | 1.30s (± 0.46%) | 1.32s (± 0.90%) | +0.01s (+ 1.07%) | 1.29s | 1.34s |
| Bind Time | 0.67s (± 0.86%) | 0.71s (± 0.78%) | +0.04s (+ 5.67%) | 0.70s | 0.72s |
| Check Time | 4.39s (± 0.49%) | 4.43s (± 0.46%) | +0.04s (+ 0.87%) | 4.38s | 4.47s |
| Emit Time | 2.84s (± 0.83%) | 2.98s (± 0.91%) | +0.14s (+ 4.79%) | 2.92s | 3.06s |
| Total Time | 9.20s (± 0.25%) | 9.43s (± 0.35%) | +0.23s (+ 2.48%) | 9.38s | 9.54s |
| Angular - node (v9.0.0, x64) | |||||
| Memory used | 350,051k (± 0.02%) | 351,729k (± 0.02%) | +1,678k (+ 0.48%) | 351,586k | 351,873k |
| Parse Time | 1.83s (± 0.73%) | 1.84s (± 0.58%) | +0.01s (+ 0.71%) | 1.82s | 1.87s |
| Bind Time | 0.82s (± 0.46%) | 0.84s (± 0.77%) | +0.03s (+ 3.31%) | 0.83s | 0.86s |
| Check Time | 4.99s (± 0.52%) | 5.06s (± 0.70%) | +0.07s (+ 1.40%) | 5.01s | 5.17s |
| Emit Time | 5.71s (± 1.57%) | 5.92s (± 0.67%) | +0.21s (+ 3.62%) | 5.85s | 6.00s |
| Total Time | 13.35s (± 0.69%) | 13.66s (± 0.23%) | +0.31s (+ 2.35%) | 13.55s | 13.71s |
| Monaco - node (v9.0.0, x64) | |||||
| Memory used | 364,056k (± 0.02%) | 365,826k (± 0.01%) | +1,769k (+ 0.49%) | 365,723k | 365,941k |
| Parse Time | 1.31s (± 0.37%) | 1.31s (± 0.72%) | -0.00s (- 0.00%) | 1.30s | 1.34s |
| Bind Time | 0.84s (± 0.73%) | 0.87s (± 1.70%) | +0.03s (+ 3.80%) | 0.85s | 0.92s |
| Check Time | 5.25s (± 1.00%) | 5.30s (± 1.26%) | +0.05s (+ 0.88%) | 5.12s | 5.38s |
| Emit Time | 2.93s (± 3.80%) | 3.10s (± 4.82%) | +0.17s (+ 5.83%) | 2.98s | 3.53s |
| Total Time | 10.34s (± 0.74%) | 10.59s (± 0.98%) | +0.25s (+ 2.38%) | 10.48s | 10.91s |
| TFS - node (v9.0.0, x64) | |||||
| Memory used | 320,733k (± 0.02%) | 323,032k (± 0.02%) | +2,299k (+ 0.72%) | 322,950k | 323,182k |
| Parse Time | 1.04s (± 0.72%) | 1.04s (± 0.50%) | -0.00s (- 0.19%) | 1.03s | 1.05s |
| Bind Time | 0.66s (± 0.67%) | 0.69s (± 0.32%) | +0.03s (+ 4.08%) | 0.68s | 0.69s |
| Check Time | 4.58s (± 0.45%) | 4.83s (± 0.45%) | +0.24s (+ 5.30%) | 4.78s | 4.87s |
| Emit Time | 3.23s (± 0.93%) | 3.06s (± 0.50%) | -0.17s (- 5.14%) | 3.03s | 3.10s |
| Total Time | 9.52s (± 0.47%) | 9.62s (± 0.35%) | +0.10s (+ 1.05%) | 9.55s | 9.67s |
| Angular - node (v9.0.0, x86) | |||||
| Memory used | 198,782k (± 0.04%) | 199,632k (± 0.02%) | +850k (+ 0.43%) | 199,531k | 199,749k |
| Parse Time | 1.73s (± 0.61%) | 1.74s (± 0.45%) | +0.01s (+ 0.75%) | 1.72s | 1.75s |
| Bind Time | 0.92s (± 0.53%) | 0.96s (± 1.13%) | +0.04s (+ 4.11%) | 0.94s | 0.99s |
| Check Time | 4.41s (± 0.68%) | 4.53s (± 0.84%) | +0.13s (+ 2.84%) | 4.45s | 4.60s |
| Emit Time | 5.55s (± 0.77%) | 5.72s (± 0.91%) | +0.17s (+ 3.06%) | 5.65s | 5.85s |
| Total Time | 12.61s (± 0.43%) | 12.96s (± 0.43%) | +0.35s (+ 2.78%) | 12.83s | 13.07s |
| Monaco - node (v9.0.0, x86) | |||||
| Memory used | 203,908k (± 0.02%) | 204,879k (± 0.02%) | +971k (+ 0.48%) | 204,756k | 204,979k |
| Parse Time | 1.35s (± 0.48%) | 1.34s (± 0.65%) | -0.01s (- 0.45%) | 1.33s | 1.36s |
| Bind Time | 0.66s (± 0.51%) | 0.68s (± 0.65%) | +0.02s (+ 2.87%) | 0.67s | 0.69s |
| Check Time | 5.14s (± 0.36%) | 5.09s (± 1.91%) | -0.06s (- 1.13%) | 4.89s | 5.24s |
| Emit Time | 2.72s (± 0.72%) | 2.99s (± 4.95%) | +0.26s (+ 9.66%) | 2.80s | 3.25s |
| Total Time | 9.88s (± 0.31%) | 10.09s (± 0.59%) | +0.21s (+ 2.18%) | 9.99s | 10.23s |
| TFS - node (v9.0.0, x86) | |||||
| Memory used | 180,553k (± 0.02%) | 181,748k (± 0.02%) | +1,195k (+ 0.66%) | 181,654k | 181,836k |
| Parse Time | 1.06s (± 0.73%) | 1.07s (± 0.77%) | +0.01s (+ 0.76%) | 1.05s | 1.09s |
| Bind Time | 0.63s (± 1.32%) | 0.65s (± 0.86%) | +0.02s (+ 3.51%) | 0.64s | 0.66s |
| Check Time | 4.31s (± 0.35%) | 4.32s (± 0.57%) | +0.01s (+ 0.23%) | 4.24s | 4.35s |
| Emit Time | 2.83s (± 0.77%) | 2.92s (± 1.30%) | +0.09s (+ 3.22%) | 2.81s | 2.99s |
| Total Time | 8.82s (± 0.30%) | 8.95s (± 0.44%) | +0.13s (+ 1.51%) | 8.86s | 9.04s |
System
| Machine Name | ts-ci-ubuntu |
|---|---|
| Platform | linux 4.4.0-161-generic |
| Architecture | x64 |
| Available Memory | 16 GB |
| Available Memory | 9 GB |
| CPUs | 4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz |
Hosts
- node (v12.1.0, x64)
- node (v8.9.0, x64)
- node (v8.9.0, x86)
- node (v9.0.0, x64)
- node (v9.0.0, x86)
Scenarios
- Angular - node (v12.1.0, x64)
- Angular - node (v8.9.0, x64)
- Angular - node (v8.9.0, x86)
- Angular - node (v9.0.0, x64)
- Angular - node (v9.0.0, x86)
- Monaco - node (v12.1.0, x64)
- Monaco - node (v8.9.0, x64)
- Monaco - node (v8.9.0, x86)
- Monaco - node (v9.0.0, x64)
- Monaco - node (v9.0.0, x86)
- TFS - node (v12.1.0, x64)
- TFS - node (v8.9.0, x64)
- TFS - node (v8.9.0, x86)
- TFS - node (v9.0.0, x64)
- TFS - node (v9.0.0, x86)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | 33294 | 10 |
| Baseline | master | 10 |