Refactor node factory API, use node factory in parser by rbuckton · Pull Request #35282 · microsoft/TypeScript (original) (raw)
@rbuckton
The results of the perf run you requested are in!
Here they are:
Comparison Report - master..35282
| Metric | master | 35282 | Delta | Best | Worst |
|---|---|---|---|---|---|
| Angular - node (v10.16.3, x64) | |||||
| Memory used | 354,603k (± 0.01%) | 334,788k (± 0.02%) | -19,815k (- 5.59%) | 334,590k | 334,926k |
| Parse Time | 1.63s (± 0.63%) | 1.98s (± 0.59%) | +0.35s (+21.24%) | 1.95s | 2.00s |
| Bind Time | 0.86s (± 0.72%) | 0.78s (± 0.64%) | -0.09s (- 9.99%) | 0.77s | 0.79s |
| Check Time | 4.53s (± 1.61%) | 4.45s (± 0.29%) | -0.08s (- 1.88%) | 4.42s | 4.48s |
| Emit Time | 5.26s (± 1.39%) | 5.13s (± 1.21%) | -0.13s (- 2.55%) | 5.00s | 5.33s |
| Total Time | 12.29s (± 1.20%) | 12.32s (± 0.53%) | +0.04s (+ 0.28%) | 12.15s | 12.51s |
| Monaco - node (v10.16.3, x64) | |||||
| Memory used | 366,191k (± 0.02%) | 340,557k (± 0.02%) | -25,634k (- 7.00%) | 340,339k | 340,676k |
| Parse Time | 1.27s (± 1.04%) | 1.57s (± 0.53%) | +0.30s (+23.42%) | 1.55s | 1.59s |
| Bind Time | 0.75s (± 0.59%) | 0.66s (± 1.21%) | -0.09s (-11.97%) | 0.65s | 0.68s |
| Check Time | 4.65s (± 0.43%) | 4.61s (± 0.59%) | -0.04s (- 0.97%) | 4.54s | 4.66s |
| Emit Time | 2.93s (± 0.70%) | 2.80s (± 0.94%) | -0.13s (- 4.27%) | 2.75s | 2.88s |
| Total Time | 9.61s (± 0.48%) | 9.64s (± 0.45%) | +0.04s (+ 0.39%) | 9.56s | 9.74s |
| TFS - node (v10.16.3, x64) | |||||
| Memory used | 322,141k (± 0.03%) | 299,598k (± 0.03%) | -22,543k (- 7.00%) | 299,317k | 299,745k |
| Parse Time | 0.96s (± 0.78%) | 1.24s (± 0.66%) | +0.28s (+29.26%) | 1.22s | 1.25s |
| Bind Time | 0.73s (± 0.92%) | 0.61s (± 0.73%) | -0.11s (-15.82%) | 0.61s | 0.63s |
| Check Time | 4.14s (± 0.71%) | 4.10s (± 0.43%) | -0.04s (- 0.94%) | 4.06s | 4.14s |
| Emit Time | 3.02s (± 1.00%) | 2.82s (± 0.80%) | -0.20s (- 6.69%) | 2.74s | 2.86s |
| Total Time | 8.84s (± 0.53%) | 8.77s (± 0.31%) | -0.08s (- 0.87%) | 8.70s | 8.82s |
| Angular - node (v12.1.0, x64) | |||||
| Memory used | 330,237k (± 0.09%) | 312,099k (± 0.02%) | -18,139k (- 5.49%) | 311,937k | 312,258k |
| Parse Time | 1.56s (± 0.47%) | 1.93s (± 0.42%) | +0.37s (+23.75%) | 1.92s | 1.95s |
| Bind Time | 0.84s (± 0.57%) | 0.74s (± 0.78%) | -0.10s (-11.59%) | 0.73s | 0.75s |
| Check Time | 4.44s (± 0.57%) | 4.36s (± 0.54%) | -0.07s (- 1.67%) | 4.30s | 4.42s |
| Emit Time | 5.46s (± 1.22%) | 5.33s (± 0.52%) | -0.13s (- 2.38%) | 5.26s | 5.39s |
| Total Time | 12.29s (± 0.65%) | 12.36s (± 0.40%) | +0.07s (+ 0.54%) | 12.26s | 12.45s |
| Monaco - node (v12.1.0, x64) | |||||
| Memory used | 345,874k (± 0.02%) | 322,943k (± 0.02%) | -22,931k (- 6.63%) | 322,755k | 323,037k |
| Parse Time | 1.23s (± 0.48%) | 1.54s (± 0.84%) | +0.31s (+25.37%) | 1.51s | 1.56s |
| Bind Time | 0.72s (± 0.97%) | 0.63s (± 0.47%) | -0.09s (-12.66%) | 0.62s | 0.63s |
| Check Time | 4.50s (± 0.53%) | 4.46s (± 0.53%) | -0.05s (- 1.00%) | 4.39s | 4.51s |
| Emit Time | 2.99s (± 1.23%) | 2.90s (± 1.20%) | -0.09s (- 3.08%) | 2.85s | 3.01s |
| Total Time | 9.44s (± 0.55%) | 9.53s (± 0.58%) | +0.09s (+ 0.93%) | 9.38s | 9.63s |
| TFS - node (v12.1.0, x64) | |||||
| Memory used | 304,436k (± 0.02%) | 283,915k (± 0.02%) | -20,522k (- 6.74%) | 283,716k | 284,049k |
| Parse Time | 0.94s (± 0.69%) | 1.25s (± 1.03%) | +0.32s (+33.80%) | 1.23s | 1.28s |
| Bind Time | 0.68s (± 0.54%) | 0.58s (± 1.11%) | -0.09s (-13.91%) | 0.57s | 0.60s |
| Check Time | 4.06s (± 0.40%) | 4.03s (± 0.49%) | -0.03s (- 0.76%) | 3.98s | 4.07s |
| Emit Time | 3.08s (± 1.15%) | 2.93s (± 1.09%) | -0.15s (- 4.88%) | 2.88s | 3.02s |
| Total Time | 8.75s (± 0.45%) | 8.79s (± 0.48%) | +0.04s (+ 0.41%) | 8.72s | 8.92s |
| Angular - node (v8.9.0, x64) | |||||
| Memory used | 349,435k (± 0.01%) | 330,992k (± 0.02%) | -18,444k (- 5.28%) | 330,896k | 331,144k |
| Parse Time | 2.10s (± 0.36%) | 2.47s (± 0.70%) | +0.37s (+17.49%) | 2.44s | 2.52s |
| Bind Time | 0.92s (± 0.75%) | 0.81s (± 0.71%) | -0.10s (-11.48%) | 0.79s | 0.82s |
| Check Time | 5.32s (± 0.86%) | 5.26s (± 0.38%) | -0.05s (- 1.02%) | 5.22s | 5.31s |
| Emit Time | 6.23s (± 0.53%) | 6.10s (± 1.15%) | -0.13s (- 2.07%) | 5.95s | 6.22s |
| Total Time | 14.57s (± 0.41%) | 14.64s (± 0.53%) | +0.08s (+ 0.54%) | 14.46s | 14.77s |
| Monaco - node (v8.9.0, x64) | |||||
| Memory used | 364,024k (± 0.01%) | 341,085k (± 0.01%) | -22,939k (- 6.30%) | 341,020k | 341,147k |
| Parse Time | 1.57s (± 0.49%) | 1.85s (± 0.35%) | +0.29s (+18.34%) | 1.84s | 1.87s |
| Bind Time | 0.93s (± 1.15%) | 0.84s (± 0.44%) | -0.08s (- 8.75%) | 0.84s | 0.85s |
| Check Time | 5.51s (± 1.64%) | 5.28s (± 0.29%) | -0.24s (- 4.33%) | 5.24s | 5.31s |
| Emit Time | 3.16s (± 4.52%) | 3.32s (± 0.75%) | +0.16s (+ 5.06%) | 3.25s | 3.37s |
| Total Time | 11.17s (± 0.84%) | 11.29s (± 0.25%) | +0.13s (+ 1.16%) | 11.23s | 11.35s |
| TFS - node (v8.9.0, x64) | |||||
| Memory used | 321,128k (± 0.02%) | 300,547k (± 0.01%) | -20,581k (- 6.41%) | 300,454k | 300,613k |
| Parse Time | 1.27s (± 0.37%) | 1.56s (± 0.40%) | +0.29s (+22.76%) | 1.55s | 1.57s |
| Bind Time | 0.74s (± 0.65%) | 0.63s (± 0.53%) | -0.11s (-14.52%) | 0.62s | 0.64s |
| Check Time | 4.74s (± 0.64%) | 4.70s (± 0.73%) | -0.04s (- 0.87%) | 4.61s | 4.79s |
| Emit Time | 3.20s (± 0.95%) | 3.01s (± 0.61%) | -0.19s (- 5.91%) | 2.96s | 3.04s |
| Total Time | 9.95s (± 0.52%) | 9.89s (± 0.51%) | -0.05s (- 0.50%) | 9.74s | 10.03s |
| Angular - node (v8.9.0, x86) | |||||
| Memory used | 198,438k (± 0.02%) | 189,538k (± 0.03%) | -8,900k (- 4.49%) | 189,396k | 189,664k |
| Parse Time | 2.03s (± 1.10%) | 2.38s (± 0.44%) | +0.35s (+17.09%) | 2.36s | 2.41s |
| Bind Time | 1.02s (± 0.85%) | 0.95s (± 0.98%) | -0.07s (- 7.24%) | 0.92s | 0.96s |
| Check Time | 4.84s (± 0.52%) | 4.72s (± 0.95%) | -0.12s (- 2.38%) | 4.65s | 4.83s |
| Emit Time | 6.09s (± 1.36%) | 5.88s (± 0.40%) | -0.21s (- 3.46%) | 5.83s | 5.93s |
| Total Time | 13.99s (± 0.66%) | 13.93s (± 0.37%) | -0.05s (- 0.39%) | 13.81s | 14.07s |
| Monaco - node (v8.9.0, x86) | |||||
| Memory used | 203,977k (± 0.02%) | 192,792k (± 0.02%) | -11,185k (- 5.48%) | 192,694k | 192,877k |
| Parse Time | 1.61s (± 0.73%) | 1.89s (± 0.96%) | +0.28s (+17.28%) | 1.86s | 1.95s |
| Bind Time | 0.75s (± 1.26%) | 0.67s (± 1.30%) | -0.08s (-10.58%) | 0.65s | 0.69s |
| Check Time | 5.41s (± 0.46%) | 5.39s (± 0.61%) | -0.02s (- 0.42%) | 5.34s | 5.47s |
| Emit Time | 2.89s (± 1.99%) | 2.70s (± 0.44%) | -0.19s (- 6.44%) | 2.68s | 2.73s |
| Total Time | 10.66s (± 0.51%) | 10.65s (± 0.50%) | -0.01s (- 0.13%) | 10.55s | 10.80s |
| TFS - node (v8.9.0, x86) | |||||
| Memory used | 181,023k (± 0.01%) | 170,863k (± 0.03%) | -10,161k (- 5.61%) | 170,780k | 170,969k |
| Parse Time | 1.32s (± 1.00%) | 1.58s (± 1.67%) | +0.26s (+20.11%) | 1.53s | 1.65s |
| Bind Time | 0.69s (± 0.72%) | 0.60s (± 1.14%) | -0.10s (-14.24%) | 0.58s | 0.61s |
| Check Time | 4.49s (± 0.53%) | 4.43s (± 0.49%) | -0.06s (- 1.23%) | 4.38s | 4.47s |
| Emit Time | 2.93s (± 0.77%) | 2.81s (± 1.39%) | -0.13s (- 4.36%) | 2.71s | 2.89s |
| Total Time | 9.43s (± 0.38%) | 9.42s (± 0.56%) | -0.02s (- 0.16%) | 9.24s | 9.49s |
System
| Machine Name | ts-ci-ubuntu |
|---|---|
| Platform | linux 4.4.0-166-generic |
| Architecture | x64 |
| Available Memory | 16 GB |
| Available Memory | 6 GB |
| CPUs | 4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz |
Hosts
- node (v10.16.3, x64)
- node (v12.1.0, x64)
- node (v8.9.0, x64)
- node (v8.9.0, x86)
Scenarios
- Angular - node (v10.16.3, x64)
- Angular - node (v12.1.0, x64)
- Angular - node (v8.9.0, x64)
- Angular - node (v8.9.0, x86)
- Monaco - node (v10.16.3, x64)
- Monaco - node (v12.1.0, x64)
- Monaco - node (v8.9.0, x64)
- Monaco - node (v8.9.0, x86)
- TFS - node (v10.16.3, x64)
- TFS - node (v12.1.0, x64)
- TFS - node (v8.9.0, x64)
- TFS - node (v8.9.0, x86)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | 35282 | 10 |
| Baseline | master | 10 |