Make tsserver and typingsInstaller thin wrappers around public API by jakebailey · Pull Request #55326 · microsoft/TypeScript (original) (raw)
@jakebailey
The results of the perf run you requested are in!
Here they are:
tsc
Comparison Report - baseline..pr
| Metric | baseline | pr | Delta | Best | Worst | p-value |
|---|---|---|---|---|---|---|
| Angular - node (v18.15.0, x64) | ||||||
| Memory used | 295,680k (± 0.01%) | 295,682k (± 0.01%) | ~ | 295,653k | 295,710k | p=0.470 n=6 |
| Parse Time | 2.66s (± 0.19%) | 2.66s (± 0.41%) | ~ | 2.65s | 2.68s | p=0.324 n=6 |
| Bind Time | 0.83s (± 0.49%) | 0.83s (± 0.66%) | ~ | 0.82s | 0.83s | p=0.282 n=6 |
| Check Time | 8.22s (± 0.28%) | 8.22s (± 0.37%) | ~ | 8.18s | 8.25s | p=0.746 n=6 |
| Emit Time | 7.16s (± 0.44%) | 7.15s (± 0.11%) | ~ | 7.14s | 7.16s | p=1.000 n=6 |
| Total Time | 18.87s (± 0.20%) | 18.86s (± 0.14%) | ~ | 18.82s | 18.88s | p=0.568 n=6 |
| Compiler-Unions - node (v18.15.0, x64) | ||||||
| Memory used | 194,367k (± 0.91%) | 193,207k (± 0.93%) | ~ | 192,012k | 195,539k | p=0.471 n=6 |
| Parse Time | 1.36s (± 1.08%) | 1.36s (± 1.43%) | ~ | 1.33s | 1.39s | p=0.683 n=6 |
| Bind Time | 0.72s (± 0.00%) | 0.72s (± 0.00%) | ~ | 0.72s | 0.72s | p=1.000 n=6 |
| Check Time | 9.53s (± 0.48%) | 9.49s (± 0.56%) | ~ | 9.43s | 9.56s | p=0.228 n=6 |
| Emit Time | 2.64s (± 0.65%) | 2.65s (± 0.53%) | ~ | 2.63s | 2.67s | p=0.370 n=6 |
| Total Time | 14.26s (± 0.45%) | 14.22s (± 0.50%) | ~ | 14.14s | 14.33s | p=0.295 n=6 |
| Monaco - node (v18.15.0, x64) | ||||||
| Memory used | 347,378k (± 0.00%) | 347,382k (± 0.00%) | ~ | 347,371k | 347,391k | p=0.748 n=6 |
| Parse Time | 2.47s (± 0.49%) | 2.48s (± 0.47%) | ~ | 2.46s | 2.49s | p=0.507 n=6 |
| Bind Time | 0.93s (± 0.90%) | 0.93s (± 0.68%) | ~ | 0.92s | 0.94s | p=0.226 n=6 |
| Check Time | 7.02s (± 0.45%) | 7.01s (± 0.31%) | ~ | 6.98s | 7.04s | p=0.517 n=6 |
| Emit Time | 4.08s (± 0.26%) | 4.07s (± 0.18%) | ~ | 4.06s | 4.08s | p=0.273 n=6 |
| Total Time | 14.49s (± 0.18%) | 14.48s (± 0.19%) | ~ | 14.43s | 14.51s | p=0.514 n=6 |
| TFS - node (v18.15.0, x64) | ||||||
| Memory used | 302,752k (± 0.01%) | 302,754k (± 0.01%) | ~ | 302,711k | 302,777k | p=0.873 n=6 |
| Parse Time | 2.01s (± 0.81%) | 2.02s (± 0.49%) | ~ | 2.01s | 2.03s | p=0.934 n=6 |
| Bind Time | 1.00s (± 0.41%) | 1.00s (± 1.09%) | ~ | 0.99s | 1.02s | p=1.000 n=6 |
| Check Time | 6.30s (± 0.34%) | 6.32s (± 0.43%) | ~ | 6.28s | 6.36s | p=0.076 n=6 |
| Emit Time | 3.60s (± 0.64%) | 3.61s (± 0.21%) | ~ | 3.60s | 3.62s | p=0.621 n=6 |
| Total Time | 12.91s (± 0.21%) | 12.95s (± 0.14%) | +0.04s (+ 0.34%) | 12.93s | 12.98s | p=0.009 n=6 |
| material-ui - node (v18.15.0, x64) | ||||||
| Memory used | 511,325k (± 0.01%) | 511,328k (± 0.01%) | ~ | 511,275k | 511,395k | p=1.000 n=6 |
| Parse Time | 2.64s (± 0.50%) | 2.65s (± 0.65%) | ~ | 2.63s | 2.67s | p=0.235 n=6 |
| Bind Time | 0.98s (± 0.85%) | 0.98s (± 0.77%) | ~ | 0.97s | 0.99s | p=0.652 n=6 |
| Check Time | 17.33s (± 0.48%) | 17.36s (± 0.57%) | ~ | 17.24s | 17.51s | p=0.747 n=6 |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | ~ | 0.00s | 0.00s | p=1.000 n=6 |
| Total Time | 20.96s (± 0.43%) | 21.00s (± 0.47%) | ~ | 20.88s | 21.15s | p=0.630 n=6 |
| mui-docs - node (v18.15.0, x64) | ||||||
| Memory used | 1,798,063k (± 0.00%) | 1,798,076k (± 0.00%) | ~ | 1,798,024k | 1,798,104k | p=0.470 n=6 |
| Parse Time | 6.64s (± 0.49%) | 6.62s (± 0.54%) | ~ | 6.59s | 6.69s | p=0.467 n=6 |
| Bind Time | 2.38s (± 0.56%) | 2.39s (± 0.46%) | ~ | 2.37s | 2.40s | p=0.140 n=6 |
| Check Time | 59.00s (± 0.22%) | 59.16s (± 0.32%) | ~ | 58.91s | 59.44s | p=0.128 n=6 |
| Emit Time | 0.17s (± 3.32%) | 0.16s (± 3.16%) | ~ | 0.16s | 0.17s | p=0.640 n=6 |
| Total Time | 68.18s (± 0.24%) | 68.34s (± 0.28%) | ~ | 68.09s | 68.59s | p=0.199 n=6 |
| self-build-src - node (v18.15.0, x64) | ||||||
| Memory used | 2,397,480k (± 0.04%) | 2,398,319k (± 0.04%) | ~ | 2,396,829k | 2,399,594k | p=0.230 n=6 |
| Parse Time | 5.05s (± 0.38%) | 5.06s (± 0.72%) | ~ | 5.00s | 5.10s | p=0.628 n=6 |
| Bind Time | 1.91s (± 0.69%) | 1.90s (± 0.98%) | ~ | 1.88s | 1.92s | p=0.418 n=6 |
| Check Time | 33.75s (± 0.35%) | 33.88s (± 0.32%) | ~ | 33.67s | 33.98s | p=0.078 n=6 |
| Emit Time | 2.68s (± 0.62%) | 2.67s (± 1.71%) | ~ | 2.61s | 2.73s | p=0.574 n=6 |
| Total Time | 43.40s (± 0.25%) | 43.53s (± 0.28%) | +0.13s (+ 0.30%) | 43.34s | 43.71s | p=0.045 n=6 |
| self-compiler - node (v18.15.0, x64) | ||||||
| Memory used | 415,428k (± 0.01%) | 415,446k (± 0.01%) | ~ | 415,400k | 415,487k | p=0.521 n=6 |
| Parse Time | 2.80s (± 1.40%) | 2.78s (± 0.54%) | ~ | 2.77s | 2.81s | p=0.289 n=6 |
| Bind Time | 1.06s (± 0.49%) | 1.07s (± 0.38%) | +0.01s (+ 0.78%) | 1.07s | 1.08s | p=0.022 n=6 |
| Check Time | 15.26s (± 0.26%) | 15.22s (± 0.18%) | -0.04s (- 0.29%) | 15.17s | 15.24s | p=0.036 n=6 |
| Emit Time | 1.09s (± 1.38%) | 1.10s (± 0.89%) | ~ | 1.09s | 1.11s | p=0.621 n=6 |
| Total Time | 20.22s (± 0.35%) | 20.17s (± 0.19%) | ~ | 20.11s | 20.21s | p=0.199 n=6 |
| vscode - node (v18.15.0, x64) | ||||||
| Memory used | 2,880,512k (± 0.00%) | 2,880,569k (± 0.00%) | ~ | 2,880,547k | 2,880,600k | p=0.109 n=6 |
| Parse Time | 10.81s (± 0.26%) | 10.81s (± 0.29%) | ~ | 10.75s | 10.83s | p=0.746 n=6 |
| Bind Time | 3.47s (± 0.34%) | 3.47s (± 0.22%) | ~ | 3.46s | 3.48s | p=0.396 n=6 |
| Check Time | 61.70s (± 0.77%) | 61.64s (± 0.47%) | ~ | 61.16s | 61.92s | p=0.936 n=6 |
| Emit Time | 17.60s (±10.10%) | 16.99s (± 8.14%) | ~ | 16.31s | 19.81s | p=0.230 n=6 |
| Total Time | 93.57s (± 2.35%) | 92.91s (± 1.61%) | ~ | 91.90s | 95.89s | p=1.000 n=6 |
| webpack - node (v18.15.0, x64) | ||||||
| Memory used | 406,564k (± 0.01%) | 406,586k (± 0.01%) | ~ | 406,508k | 406,666k | p=0.471 n=6 |
| Parse Time | 3.19s (± 1.28%) | 3.20s (± 0.73%) | ~ | 3.17s | 3.23s | p=0.746 n=6 |
| Bind Time | 1.38s (± 0.60%) | 1.38s (± 1.48%) | ~ | 1.36s | 1.42s | p=0.280 n=6 |
| Check Time | 14.26s (± 0.30%) | 14.27s (± 0.34%) | ~ | 14.22s | 14.34s | p=1.000 n=6 |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | ~ | 0.00s | 0.00s | p=1.000 n=6 |
| Total Time | 18.84s (± 0.23%) | 18.85s (± 0.39%) | ~ | 18.76s | 18.95s | p=1.000 n=6 |
| xstate - node (v18.15.0, x64) | ||||||
| Memory used | 513,267k (± 0.01%) | 513,238k (± 0.01%) | ~ | 513,166k | 513,278k | p=0.575 n=6 |
| Parse Time | 3.28s (± 0.25%) | 3.28s (± 0.36%) | ~ | 3.26s | 3.29s | p=0.738 n=6 |
| Bind Time | 1.54s (± 0.49%) | 1.54s (± 0.41%) | ~ | 1.53s | 1.55s | p=0.718 n=6 |
| Check Time | 2.86s (± 0.76%) | 2.86s (± 0.95%) | ~ | 2.82s | 2.90s | p=1.000 n=6 |
| Emit Time | 0.07s (± 0.00%) | 0.07s (± 0.00%) | ~ | 0.07s | 0.07s | p=1.000 n=6 |
| Total Time | 7.75s (± 0.43%) | 7.75s (± 0.44%) | ~ | 7.70s | 7.80s | p=0.936 n=6 |
System info unknown
Hosts
- node (v18.15.0, x64)
Scenarios
- Angular - node (v18.15.0, x64)
- Compiler-Unions - node (v18.15.0, x64)
- Monaco - node (v18.15.0, x64)
- TFS - node (v18.15.0, x64)
- material-ui - node (v18.15.0, x64)
- mui-docs - node (v18.15.0, x64)
- self-build-src - node (v18.15.0, x64)
- self-compiler - node (v18.15.0, x64)
- vscode - node (v18.15.0, x64)
- webpack - node (v18.15.0, x64)
- xstate - node (v18.15.0, x64)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | pr | 6 |
| Baseline | baseline | 6 |
tsserver
Comparison Report - baseline..pr
| Metric | baseline | pr | Delta | Best | Worst | p-value |
|---|---|---|---|---|---|---|
| Compiler-UnionsTSServer - node (v18.15.0, x64) | ||||||
| Req 1 - updateOpen | 2,355ms (± 0.62%) | 2,346ms (± 0.75%) | ~ | 2,325ms | 2,370ms | p=0.470 n=6 |
| Req 2 - geterr | 5,683ms (± 1.53%) | 5,745ms (± 1.79%) | ~ | 5,601ms | 5,824ms | p=0.378 n=6 |
| Req 3 - references | 321ms (± 0.76%) | 343ms (± 8.47%) | 🔻+22ms (+ 6.70%) | 323ms | 380ms | p=0.035 n=6 |
| Req 4 - navto | 276ms (± 0.42%) | 270ms (± 2.24%) | -6ms (- 2.11%) | 258ms | 273ms | p=0.004 n=6 |
| Req 5 - completionInfo count | 1,357 (± 0.00%) | 1,357 (± 0.00%) | ~ | 1,357 | 1,357 | p=1.000 n=6 |
| Req 5 - completionInfo | 83ms (± 3.03%) | 91ms (± 6.40%) | ~ | 83ms | 95ms | p=0.071 n=6 |
| CompilerTSServer - node (v18.15.0, x64) | ||||||
| Req 1 - updateOpen | 2,517ms (± 0.55%) | 2,489ms (± 0.73%) | -28ms (- 1.11%) | 2,470ms | 2,520ms | p=0.013 n=6 |
| Req 2 - geterr | 4,218ms (± 2.06%) | 4,146ms (± 0.27%) | ~ | 4,130ms | 4,157ms | p=0.378 n=6 |
| Req 3 - references | 332ms (± 0.68%) | 339ms (± 0.91%) | +7ms (+ 2.11%) | 335ms | 342ms | p=0.006 n=6 |
| Req 4 - navto | 285ms (± 0.52%) | 290ms (± 2.40%) | ~ | 284ms | 303ms | p=0.141 n=6 |
| Req 5 - completionInfo count | 1,519 (± 0.00%) | 1,519 (± 0.00%) | ~ | 1,519 | 1,519 | p=1.000 n=6 |
| Req 5 - completionInfo | 81ms (± 7.27%) | 86ms (± 7.08%) | ~ | 78ms | 90ms | p=0.176 n=6 |
| xstateTSServer - node (v18.15.0, x64) | ||||||
| Req 1 - updateOpen | 2,614ms (± 0.20%) | 2,616ms (± 0.24%) | ~ | 2,605ms | 2,623ms | p=0.520 n=6 |
| Req 2 - geterr | 1,728ms (± 2.10%) | 1,767ms (± 0.75%) | ~ | 1,747ms | 1,786ms | p=0.065 n=6 |
| Req 3 - references | 120ms (± 8.22%) | 119ms (± 8.38%) | ~ | 105ms | 126ms | p=0.467 n=6 |
| Req 4 - navto | 370ms (± 0.75%) | 367ms (± 0.42%) | -3ms (- 0.86%) | 364ms | 368ms | p=0.043 n=6 |
| Req 5 - completionInfo count | 2,079 (± 0.00%) | 2,079 (± 0.00%) | ~ | 2,079 | 2,079 | p=1.000 n=6 |
| Req 5 - completionInfo | 306ms (± 1.69%) | 309ms (± 0.91%) | ~ | 306ms | 314ms | p=0.422 n=6 |
System info unknown
Hosts
- node (v18.15.0, x64)
Scenarios
- CompilerTSServer - node (v18.15.0, x64)
- Compiler-UnionsTSServer - node (v18.15.0, x64)
- xstateTSServer - node (v18.15.0, x64)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | pr | 6 |
| Baseline | baseline | 6 |
startup
Comparison Report - baseline..pr
| Metric | baseline | pr | Delta | Best | Worst | p-value |
|---|---|---|---|---|---|---|
| tsc-startup - node (v18.15.0, x64) | ||||||
| Execution time | 153.21ms (± 0.17%) | 153.23ms (± 0.17%) | ~ | 152.16ms | 156.10ms | p=0.992 n=600 |
| tsserver-startup - node (v18.15.0, x64) | ||||||
| Execution time | 229.56ms (± 0.16%) | 243.45ms (± 0.86%) | 🔻+13.89ms (+ 6.05%) | 241.54ms | 280.25ms | p=0.000 n=600 |
| tsserverlibrary-startup - node (v18.15.0, x64) | ||||||
| Execution time | 222.64ms (± 0.14%) | 222.89ms (± 0.16%) | +0.25ms (+ 0.11%) | 221.42ms | 229.26ms | p=0.000 n=600 |
| typescript-startup - node (v18.15.0, x64) | ||||||
| Execution time | 221.47ms (± 0.14%) | 221.47ms (± 0.15%) | ~ | 220.11ms | 225.85ms | p=0.957 n=600 |
System info unknown
Hosts
- node (v18.15.0, x64)
Scenarios
- tsc-startup - node (v18.15.0, x64)
- tsserver-startup - node (v18.15.0, x64)
- tsserverlibrary-startup - node (v18.15.0, x64)
- typescript-startup - node (v18.15.0, x64)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | pr | 6 |
| Baseline | baseline | 6 |
Developer Information: