"Annotate" exported object to fix named / namespace imports of our API in Node ESM by jakebailey · Pull Request #57133 · microsoft/TypeScript (original) (raw)
@jakebailey
The results of the perf run you requested are in!
Here they are:
tsc
Comparison Report - baseline..pr
| Metric | baseline | pr | Delta | Best | Worst | p-value |
|---|---|---|---|---|---|---|
| Angular - node (v18.15.0, x64) | ||||||
| Memory used | 295,641k (± 0.01%) | 295,659k (± 0.01%) | ~ | 295,628k | 295,708k | p=0.296 n=6 |
| Parse Time | 2.66s (± 0.31%) | 2.67s (± 0.31%) | ~ | 2.66s | 2.68s | p=1.000 n=6 |
| Bind Time | 0.83s (± 0.62%) | 0.83s (± 1.08%) | ~ | 0.82s | 0.84s | p=0.541 n=6 |
| Check Time | 8.19s (± 0.18%) | 8.19s (± 0.34%) | ~ | 8.15s | 8.23s | p=0.742 n=6 |
| Emit Time | 7.09s (± 0.37%) | 7.12s (± 0.66%) | ~ | 7.07s | 7.20s | p=0.198 n=6 |
| Total Time | 18.77s (± 0.18%) | 18.81s (± 0.30%) | ~ | 18.73s | 18.88s | p=0.260 n=6 |
| Compiler-Unions - node (v18.15.0, x64) | ||||||
| Memory used | 193,926k (± 1.46%) | 193,910k (± 1.48%) | ~ | 191,496k | 197,406k | p=0.689 n=6 |
| Parse Time | 1.35s (± 0.81%) | 1.36s (± 0.77%) | +0.01s (+ 1.11%) | 1.35s | 1.38s | p=0.046 n=6 |
| Bind Time | 0.72s (± 0.00%) | 0.72s (± 0.00%) | ~ | 0.72s | 0.72s | p=1.000 n=6 |
| Check Time | 9.35s (± 0.40%) | 9.35s (± 0.34%) | ~ | 9.31s | 9.40s | p=0.808 n=6 |
| Emit Time | 2.61s (± 0.45%) | 2.61s (± 0.86%) | ~ | 2.60s | 2.66s | p=0.933 n=6 |
| Total Time | 14.04s (± 0.24%) | 14.04s (± 0.30%) | ~ | 14.00s | 14.10s | p=0.936 n=6 |
| Monaco - node (v18.15.0, x64) | ||||||
| Memory used | 347,455k (± 0.00%) | 347,450k (± 0.00%) | ~ | 347,438k | 347,481k | p=0.520 n=6 |
| Parse Time | 2.47s (± 0.61%) | 2.48s (± 0.47%) | ~ | 2.47s | 2.50s | p=0.367 n=6 |
| Bind Time | 0.93s (± 0.00%) | 0.93s (± 0.44%) | ~ | 0.92s | 0.93s | p=0.405 n=6 |
| Check Time | 6.93s (± 0.61%) | 6.91s (± 0.18%) | ~ | 6.90s | 6.93s | p=1.000 n=6 |
| Emit Time | 4.06s (± 0.29%) | 4.05s (± 0.40%) | ~ | 4.03s | 4.07s | p=0.285 n=6 |
| Total Time | 14.39s (± 0.29%) | 14.37s (± 0.13%) | ~ | 14.35s | 14.40s | p=0.517 n=6 |
| TFS - node (v18.15.0, x64) | ||||||
| Memory used | 302,860k (± 0.01%) | 302,840k (± 0.00%) | ~ | 302,823k | 302,860k | p=0.378 n=6 |
| Parse Time | 2.01s (± 0.77%) | 2.01s (± 0.73%) | ~ | 1.99s | 2.03s | p=0.934 n=6 |
| Bind Time | 1.01s (± 0.81%) | 1.00s (± 0.98%) | ~ | 0.99s | 1.02s | p=0.282 n=6 |
| Check Time | 6.32s (± 0.33%) | 6.32s (± 0.19%) | ~ | 6.31s | 6.34s | p=0.803 n=6 |
| Emit Time | 3.60s (± 0.42%) | 3.60s (± 0.66%) | ~ | 3.57s | 3.63s | p=0.935 n=6 |
| Total Time | 12.94s (± 0.20%) | 12.93s (± 0.23%) | ~ | 12.90s | 12.99s | p=0.934 n=6 |
| material-ui - node (v18.15.0, x64) | ||||||
| Memory used | 511,289k (± 0.00%) | 511,298k (± 0.00%) | ~ | 511,276k | 511,325k | p=0.336 n=6 |
| Parse Time | 2.65s (± 0.41%) | 2.65s (± 0.74%) | ~ | 2.63s | 2.68s | p=0.555 n=6 |
| Bind Time | 1.00s (± 1.05%) | 1.00s (± 0.63%) | ~ | 0.99s | 1.01s | p=0.388 n=6 |
| Check Time | 17.26s (± 0.42%) | 17.18s (± 0.48%) | ~ | 17.04s | 17.27s | p=0.196 n=6 |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | ~ | 0.00s | 0.00s | p=1.000 n=6 |
| Total Time | 20.90s (± 0.35%) | 20.84s (± 0.37%) | ~ | 20.70s | 20.91s | p=0.295 n=6 |
| mui-docs - node (v18.15.0, x64) | ||||||
| Memory used | 1,696,143k (± 0.00%) | 1,696,112k (± 0.00%) | ~ | 1,696,066k | 1,696,173k | p=0.199 n=6 |
| Parse Time | 6.54s (± 0.22%) | 6.54s (± 0.34%) | ~ | 6.52s | 6.58s | p=0.622 n=6 |
| Bind Time | 2.35s (± 0.42%) | 2.36s (± 0.51%) | ~ | 2.34s | 2.37s | p=0.507 n=6 |
| Check Time | 55.42s (± 0.56%) | 55.47s (± 0.44%) | ~ | 55.18s | 55.90s | p=0.872 n=6 |
| Emit Time | 0.16s (± 0.00%) | 0.16s (± 2.52%) | ~ | 0.16s | 0.17s | p=0.405 n=6 |
| Total Time | 64.47s (± 0.49%) | 64.52s (± 0.38%) | ~ | 64.22s | 64.95s | p=0.810 n=6 |
| self-build-src - node (v18.15.0, x64) | ||||||
| Memory used | 2,413,093k (± 0.03%) | 2,412,933k (± 0.01%) | ~ | 2,412,681k | 2,413,207k | p=1.000 n=6 |
| Parse Time | 4.94s (± 0.78%) | 4.93s (± 0.86%) | ~ | 4.87s | 4.98s | p=0.936 n=6 |
| Bind Time | 1.87s (± 0.99%) | 1.88s (± 0.82%) | ~ | 1.87s | 1.90s | p=0.797 n=6 |
| Check Time | 33.42s (± 0.23%) | 33.51s (± 0.50%) | ~ | 33.29s | 33.76s | p=0.230 n=6 |
| Emit Time | 2.70s (± 0.80%) | 2.69s (± 0.99%) | ~ | 2.66s | 2.74s | p=0.520 n=6 |
| Total Time | 42.95s (± 0.23%) | 43.04s (± 0.27%) | ~ | 42.90s | 43.21s | p=0.230 n=6 |
| self-compiler - node (v18.15.0, x64) | ||||||
| Memory used | 419,692k (± 0.01%) | 419,705k (± 0.01%) | ~ | 419,663k | 419,745k | p=0.689 n=6 |
| Parse Time | 2.71s (± 2.34%) | 2.73s (± 2.87%) | ~ | 2.65s | 2.82s | p=0.872 n=6 |
| Bind Time | 1.17s (± 6.20%) | 1.14s (± 6.58%) | ~ | 1.07s | 1.22s | p=0.413 n=6 |
| Check Time | 15.11s (± 0.32%) | 15.11s (± 0.18%) | ~ | 15.06s | 15.13s | p=0.936 n=6 |
| Emit Time | 1.16s (± 1.84%) | 1.16s (± 1.19%) | ~ | 1.14s | 1.18s | p=0.677 n=6 |
| Total Time | 20.16s (± 0.38%) | 20.14s (± 0.11%) | ~ | 20.12s | 20.18s | p=1.000 n=6 |
| vscode - node (v18.15.0, x64) | ||||||
| Memory used | 2,807,583k (± 0.00%) | 2,807,625k (± 0.00%) | ~ | 2,807,540k | 2,807,696k | p=0.173 n=6 |
| Parse Time | 10.62s (± 0.23%) | 10.63s (± 0.28%) | ~ | 10.59s | 10.67s | p=0.469 n=6 |
| Bind Time | 3.39s (± 0.26%) | 3.38s (± 0.44%) | ~ | 3.37s | 3.41s | p=0.284 n=6 |
| Check Time | 59.57s (± 0.31%) | 59.56s (± 0.18%) | ~ | 59.41s | 59.71s | p=0.873 n=6 |
| Emit Time | 16.15s (± 0.52%) | 16.11s (± 0.39%) | ~ | 16.00s | 16.18s | p=1.000 n=6 |
| Total Time | 89.72s (± 0.27%) | 89.69s (± 0.09%) | ~ | 89.58s | 89.76s | p=0.872 n=6 |
| webpack - node (v18.15.0, x64) | ||||||
| Memory used | 392,437k (± 0.01%) | 392,467k (± 0.02%) | ~ | 392,398k | 392,622k | p=0.689 n=6 |
| Parse Time | 3.08s (± 0.57%) | 3.06s (± 1.04%) | ~ | 3.02s | 3.11s | p=0.418 n=6 |
| Bind Time | 1.40s (± 0.54%) | 1.40s (± 0.99%) | ~ | 1.38s | 1.41s | p=0.453 n=6 |
| Check Time | 13.96s (± 0.32%) | 13.96s (± 0.31%) | ~ | 13.92s | 14.04s | p=0.747 n=6 |
| Emit Time | 0.00s (± 0.00%) | 0.00s (± 0.00%) | ~ | 0.00s | 0.00s | p=1.000 n=6 |
| Total Time | 18.43s (± 0.26%) | 18.42s (± 0.25%) | ~ | 18.37s | 18.49s | p=0.810 n=6 |
| xstate - node (v18.15.0, x64) | ||||||
| Memory used | 513,392k (± 0.01%) | 513,428k (± 0.01%) | ~ | 513,355k | 513,505k | p=0.230 n=6 |
| Parse Time | 3.29s (± 0.31%) | 3.28s (± 0.26%) | ~ | 3.26s | 3.28s | p=0.065 n=6 |
| Bind Time | 1.54s (± 0.53%) | 1.54s (± 0.54%) | ~ | 1.54s | 1.56s | p=0.673 n=6 |
| Check Time | 2.85s (± 0.76%) | 2.85s (± 0.38%) | ~ | 2.83s | 2.86s | p=1.000 n=6 |
| Emit Time | 0.08s (± 0.00%) | 0.08s (± 0.00%) | ~ | 0.08s | 0.08s | p=1.000 n=6 |
| Total Time | 7.76s (± 0.23%) | 7.75s (± 0.10%) | ~ | 7.74s | 7.76s | p=1.000 n=6 |
System info unknown
Hosts
- node (v18.15.0, x64)
Scenarios
- Angular - node (v18.15.0, x64)
- Compiler-Unions - node (v18.15.0, x64)
- Monaco - node (v18.15.0, x64)
- TFS - node (v18.15.0, x64)
- material-ui - node (v18.15.0, x64)
- mui-docs - node (v18.15.0, x64)
- self-build-src - node (v18.15.0, x64)
- self-compiler - node (v18.15.0, x64)
- vscode - node (v18.15.0, x64)
- webpack - node (v18.15.0, x64)
- xstate - node (v18.15.0, x64)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | pr | 6 |
| Baseline | baseline | 6 |
tsserver
Comparison Report - baseline..pr
| Metric | baseline | pr | Delta | Best | Worst | p-value |
|---|---|---|---|---|---|---|
| Compiler-UnionsTSServer - node (v18.15.0, x64) | ||||||
| Req 1 - updateOpen | 2,351ms (± 0.32%) | 2,352ms (± 0.66%) | ~ | 2,332ms | 2,377ms | p=1.000 n=6 |
| Req 2 - geterr | 5,490ms (± 1.16%) | 5,492ms (± 1.56%) | ~ | 5,415ms | 5,603ms | p=0.575 n=6 |
| Req 3 - references | 322ms (± 0.48%) | 323ms (± 0.51%) | ~ | 321ms | 325ms | p=0.438 n=6 |
| Req 4 - navto | 277ms (± 1.31%) | 276ms (± 1.28%) | ~ | 271ms | 279ms | p=0.438 n=6 |
| Req 5 - completionInfo count | 1,356 (± 0.00%) | 1,356 (± 0.00%) | ~ | 1,356 | 1,356 | p=1.000 n=6 |
| Req 5 - completionInfo | 85ms (± 5.36%) | 85ms (± 7.43%) | ~ | 79ms | 93ms | p=1.000 n=6 |
| CompilerTSServer - node (v18.15.0, x64) | ||||||
| Req 1 - updateOpen | 2,468ms (± 1.19%) | 2,472ms (± 1.32%) | ~ | 2,413ms | 2,506ms | p=0.575 n=6 |
| Req 2 - geterr | 4,173ms (± 1.96%) | 4,233ms (± 1.77%) | ~ | 4,134ms | 4,296ms | p=0.093 n=6 |
| Req 3 - references | 338ms (± 1.64%) | 336ms (± 1.62%) | ~ | 331ms | 343ms | p=0.746 n=6 |
| Req 4 - navto | 285ms (± 0.41%) | 284ms (± 0.36%) | ~ | 283ms | 286ms | p=0.456 n=6 |
| Req 5 - completionInfo count | 1,518 (± 0.00%) | 1,518 (± 0.00%) | ~ | 1,518 | 1,518 | p=1.000 n=6 |
| Req 5 - completionInfo | 84ms (± 7.13%) | 85ms (± 6.65%) | ~ | 78ms | 90ms | p=0.683 n=6 |
| xstateTSServer - node (v18.15.0, x64) | ||||||
| Req 1 - updateOpen | 2,610ms (± 0.46%) | 2,614ms (± 0.66%) | ~ | 2,580ms | 2,626ms | p=0.261 n=6 |
| Req 2 - geterr | 1,739ms (± 1.70%) | 1,715ms (± 2.21%) | ~ | 1,660ms | 1,747ms | p=0.149 n=6 |
| Req 3 - references | 124ms (± 6.95%) | 110ms (± 7.26%) | 🟩-14ms (-11.07%) | 105ms | 126ms | p=0.043 n=6 |
| Req 4 - navto | 370ms (± 0.22%) | 371ms (± 0.11%) | ~ | 370ms | 371ms | p=0.248 n=6 |
| Req 5 - completionInfo count | 2,078 (± 0.00%) | 2,078 (± 0.00%) | ~ | 2,078 | 2,078 | p=1.000 n=6 |
| Req 5 - completionInfo | 312ms (± 1.48%) | 311ms (± 1.46%) | ~ | 304ms | 316ms | p=0.746 n=6 |
System info unknown
Hosts
- node (v18.15.0, x64)
Scenarios
- CompilerTSServer - node (v18.15.0, x64)
- Compiler-UnionsTSServer - node (v18.15.0, x64)
- xstateTSServer - node (v18.15.0, x64)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | pr | 6 |
| Baseline | baseline | 6 |
startup
Comparison Report - baseline..pr
| Metric | baseline | pr | Delta | Best | Worst | p-value |
|---|---|---|---|---|---|---|
| tsc-startup - node (v18.15.0, x64) | ||||||
| Execution time | 154.08ms (± 0.19%) | 153.86ms (± 0.19%) | -0.22ms (- 0.14%) | 152.74ms | 157.53ms | p=0.000 n=600 |
| tsserver-startup - node (v18.15.0, x64) | ||||||
| Execution time | 229.82ms (± 0.17%) | 229.62ms (± 0.17%) | -0.21ms (- 0.09%) | 228.06ms | 235.49ms | p=0.000 n=600 |
| tsserverlibrary-startup - node (v18.15.0, x64) | ||||||
| Execution time | 231.44ms (± 0.19%) | 232.80ms (± 0.18%) | +1.37ms (+ 0.59%) | 231.10ms | 239.00ms | p=0.000 n=600 |
| typescript-startup - node (v18.15.0, x64) | ||||||
| Execution time | 231.16ms (± 0.19%) | 232.48ms (± 0.17%) | +1.32ms (+ 0.57%) | 230.92ms | 236.22ms | p=0.000 n=600 |
System info unknown
Hosts
- node (v18.15.0, x64)
Scenarios
- tsc-startup - node (v18.15.0, x64)
- tsserver-startup - node (v18.15.0, x64)
- tsserverlibrary-startup - node (v18.15.0, x64)
- typescript-startup - node (v18.15.0, x64)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | pr | 6 |
| Baseline | baseline | 6 |
Developer Information: