[experimental] Force strict binding by jakebailey · Pull Request #61888 · microsoft/TypeScript (original) (raw)
@jakebailey
The results of the perf run you requested are in!
Here they are:
tsc
Comparison Report - baseline..pr
| Metric | baseline | pr | Delta | Best | Worst | p-value |
|---|---|---|---|---|---|---|
| Compiler-Unions - node (v18.15.0, x64) | ||||||
| Errors | 34 | 34 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 62,370 | 62,370 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 50,386 | 50,386 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 193,506k (± 0.76%) | 193,492k (± 0.77%) | ~ | 192,859k | 196,543k | p=0.230 n=6 |
| Parse Time | 1.30s (± 0.79%) | 1.31s (± 0.62%) | ~ | 1.29s | 1.31s | p=0.595 n=6 |
| Bind Time | 0.73s | 0.73s | ~ | ~ | ~ | p=1.000 n=6 |
| Check Time | 9.69s (± 0.27%) | 9.69s (± 0.39%) | ~ | 9.65s | 9.75s | p=0.872 n=6 |
| Emit Time | 2.73s (± 0.82%) | 2.76s (± 0.53%) | +0.03s (+ 0.98%) | 2.74s | 2.78s | p=0.043 n=6 |
| Total Time | 14.46s (± 0.19%) | 14.48s (± 0.34%) | ~ | 14.43s | 14.56s | p=0.684 n=6 |
| angular-1 - node (v18.15.0, x64) | ||||||
| Errors | 56 | 56 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 948,750 | 948,750 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 410,846 | 410,846 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 1,224,613k (± 0.01%) | 1,224,577k (± 0.00%) | ~ | 1,224,492k | 1,224,651k | p=0.575 n=6 |
| Parse Time | 6.64s (± 0.82%) | 6.63s (± 1.11%) | ~ | 6.50s | 6.71s | p=1.000 n=6 |
| Bind Time | 1.88s (± 0.71%) | 1.88s (± 0.45%) | ~ | 1.86s | 1.88s | p=0.506 n=6 |
| Check Time | 31.70s (± 0.43%) | 31.78s (± 0.37%) | ~ | 31.67s | 31.96s | p=0.423 n=6 |
| Emit Time | 14.98s (± 0.90%) | 14.95s (± 0.65%) | ~ | 14.78s | 15.06s | p=0.521 n=6 |
| Total Time | 55.20s (± 0.27%) | 55.24s (± 0.43%) | ~ | 54.92s | 55.49s | p=0.872 n=6 |
| mui-docs - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 2,509,169 | 2,509,169 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 892,704 | 892,704 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 2,804,172k (± 0.00%) | 2,804,169k (± 0.00%) | ~ | 2,804,107k | 2,804,245k | p=0.689 n=6 |
| Parse Time | 10.66s (± 0.31%) | 10.67s (± 0.68%) | ~ | 10.55s | 10.73s | p=0.467 n=6 |
| Bind Time | 2.74s (± 0.76%) | 2.74s (± 1.29%) | ~ | 2.68s | 2.77s | p=0.808 n=6 |
| Check Time | 101.73s (± 1.02%) | 102.12s (± 1.63%) | ~ | 100.31s | 104.57s | p=0.936 n=6 |
| Emit Time | 0.37s (± 2.22%) | 0.37s (± 3.30%) | ~ | 0.35s | 0.38s | p=1.000 n=6 |
| Total Time | 115.50s (± 0.88%) | 115.89s (± 1.40%) | ~ | 114.14s | 118.37s | p=0.936 n=6 |
| self-build-src - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 1,227,126 | 1,227,126 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 267,408 | 267,408 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 2,361,866k (± 0.03%) | 2,361,574k (± 0.01%) | ~ | 2,361,200k | 2,361,927k | p=0.471 n=6 |
| Parse Time | 5.20s (± 0.90%) | 5.20s (± 0.99%) | ~ | 5.13s | 5.26s | p=0.936 n=6 |
| Bind Time | 1.81s (± 0.57%) | 1.80s (± 0.23%) | ~ | 1.79s | 1.80s | p=0.101 n=6 |
| Check Time | 35.32s (± 0.58%) | 35.16s (± 0.26%) | ~ | 35.06s | 35.28s | p=0.128 n=6 |
| Emit Time | 3.03s (± 3.19%) | 3.00s (± 2.96%) | ~ | 2.93s | 3.17s | p=0.377 n=6 |
| Total Time | 45.38s (± 0.55%) | 45.16s (± 0.28%) | ~ | 45.01s | 45.32s | p=0.128 n=6 |
| self-build-src-public-api - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 1,227,126 | 1,227,126 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 267,408 | 267,408 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 2,429,116k (± 0.03%) | 2,429,124k (± 0.02%) | ~ | 2,428,387k | 2,429,537k | p=1.000 n=6 |
| Parse Time | 5.40s (± 0.52%) | 5.42s (± 0.25%) | ~ | 5.40s | 5.44s | p=0.063 n=6 |
| Bind Time | 1.83s (± 0.77%) | 1.82s (± 0.92%) | ~ | 1.80s | 1.85s | p=0.251 n=6 |
| Check Time | 35.16s (± 0.28%) | 35.16s (± 0.35%) | ~ | 34.98s | 35.35s | p=1.000 n=6 |
| Emit Time | 3.02s (± 0.84%) | 3.10s (± 2.62%) | ~ | 3.01s | 3.22s | p=0.093 n=6 |
| Total Time | 45.41s (± 0.31%) | 45.50s (± 0.39%) | ~ | 45.23s | 45.70s | p=0.471 n=6 |
| self-compiler - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 262,474 | 262,474 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 107,135 | 107,135 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 441,699k (± 0.01%) | 441,710k (± 0.01%) | ~ | 441,641k | 441,788k | p=0.810 n=6 |
| Parse Time | 3.52s (± 0.86%) | 3.57s (± 1.11%) | +0.06s (+ 1.61%) | 3.52s | 3.64s | p=0.024 n=6 |
| Bind Time | 1.32s (± 1.14%) | 1.31s (± 1.22%) | ~ | 1.29s | 1.34s | p=0.720 n=6 |
| Check Time | 18.86s (± 0.46%) | 18.86s (± 0.16%) | ~ | 18.80s | 18.88s | p=0.872 n=6 |
| Emit Time | 1.52s (± 1.15%) | 1.52s (± 0.54%) | ~ | 1.51s | 1.53s | p=0.508 n=6 |
| Total Time | 25.22s (± 0.37%) | 25.27s (± 0.23%) | ~ | 25.21s | 25.35s | p=0.146 n=6 |
| ts-pre-modules - node (v18.15.0, x64) | ||||||
| Errors | 71 | 71 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 225,327 | 225,327 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 94,288 | 94,288 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 371,285k (± 0.05%) | 371,094k (± 0.02%) | ~ | 371,001k | 371,192k | p=0.054 n=6 |
| Parse Time | 2.90s (± 1.17%) | 2.88s (± 0.85%) | ~ | 2.85s | 2.90s | p=0.368 n=6 |
| Bind Time | 1.59s (± 1.28%) | 1.58s (± 0.87%) | ~ | 1.56s | 1.60s | p=1.000 n=6 |
| Check Time | 16.36s (± 0.29%) | 16.34s (± 0.31%) | ~ | 16.26s | 16.39s | p=0.573 n=6 |
| Emit Time | 0.00s | 0.00s | ~ | ~ | ~ | p=1.000 n=6 |
| Total Time | 20.85s (± 0.32%) | 20.81s (± 0.22%) | ~ | 20.73s | 20.87s | p=0.126 n=6 |
| vscode - node (v18.15.0, x64) | ||||||
| Errors | 33 | 33 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 3,487,921 | 3,487,921 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 1,172,723 | 1,172,723 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 3,536,052k (± 0.01%) | 3,536,239k (± 0.01%) | ~ | 3,535,840k | 3,536,433k | p=0.173 n=6 |
| Parse Time | 14.99s (± 0.50%) | 15.00s (± 0.33%) | ~ | 14.92s | 15.05s | p=1.000 n=6 |
| Bind Time | 4.89s (± 0.75%) | 4.88s (± 0.35%) | ~ | 4.85s | 4.90s | p=0.570 n=6 |
| Check Time | 95.77s (± 3.36%) | 96.09s (± 3.05%) | ~ | 93.47s | 101.11s | p=0.689 n=6 |
| Emit Time | 30.72s (± 3.20%) | 30.33s (± 2.76%) | ~ | 29.29s | 31.37s | p=0.689 n=6 |
| Total Time | 146.36s (± 2.49%) | 146.30s (± 2.29%) | ~ | 142.65s | 152.43s | p=0.810 n=6 |
| webpack - node (v18.15.0, x64) | ||||||
| Errors | 2 | 2 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 317,913 | 317,913 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 137,661 | 137,661 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 471,838k (± 0.03%) | 472,038k (± 0.03%) | +200k (+ 0.04%) | 471,890k | 472,236k | p=0.045 n=6 |
| Parse Time | 4.32s (± 0.24%) | 4.32s (± 0.36%) | ~ | 4.31s | 4.35s | p=0.397 n=6 |
| Bind Time | 1.76s (± 1.45%) | 1.78s (± 0.98%) | ~ | 1.75s | 1.80s | p=0.329 n=6 |
| Check Time | 20.53s (± 0.58%) | 20.68s (± 0.27%) | +0.15s (+ 0.76%) | 20.61s | 20.76s | p=0.020 n=6 |
| Emit Time | 0.00s | 0.00s | ~ | ~ | ~ | p=1.000 n=6 |
| Total Time | 26.61s (± 0.52%) | 26.78s (± 0.16%) | +0.17s (+ 0.65%) | 26.73s | 26.84s | p=0.029 n=6 |
| xstate-main - node (v18.15.0, x64) | ||||||
| Errors | 30 | 30 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 667,374 | 667,374 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 198,751 | 198,751 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 570,108k (± 0.00%) | 570,084k (± 0.01%) | ~ | 570,039k | 570,169k | p=0.230 n=6 |
| Parse Time | 5.54s (± 0.54%) | 5.56s (± 0.31%) | ~ | 5.53s | 5.58s | p=0.256 n=6 |
| Bind Time | 1.65s (± 0.62%) | 1.65s (± 1.19%) | ~ | 1.61s | 1.67s | p=0.720 n=6 |
| Check Time | 25.32s (± 0.29%) | 25.33s (± 0.66%) | ~ | 25.10s | 25.60s | p=0.936 n=6 |
| Emit Time | 0.00s | 0.00s | ~ | ~ | ~ | p=1.000 n=6 |
| Total Time | 32.51s (± 0.18%) | 32.53s (± 0.44%) | ~ | 32.34s | 32.77s | p=0.575 n=6 |
System info unknown
Hosts
- node (v18.15.0, x64)
Scenarios
- Compiler-Unions - node (v18.15.0, x64)
- angular-1 - node (v18.15.0, x64)
- mui-docs - node (v18.15.0, x64)
- self-build-src - node (v18.15.0, x64)
- self-build-src-public-api - node (v18.15.0, x64)
- self-compiler - node (v18.15.0, x64)
- ts-pre-modules - node (v18.15.0, x64)
- vscode - node (v18.15.0, x64)
- webpack - node (v18.15.0, x64)
- xstate-main - node (v18.15.0, x64)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | pr | 6 |
| Baseline | baseline | 6 |
Developer Information: