fix: #1802 confirm cached credential before rejecting by tyrielv · Pull Request #1803 · microsoft/VFSForGit (original) (raw)

I left a few nits based on the repo style guide, but they aren't critical.

Also, I merged your change with mine in #1804 to make sure that everything built, passed unit tests, and ran against a full production repo just fine. The merge is in derrickstolee:oath-change-2024.

I'm currently running the default functional test suite as an extra precaution, but I don't anticipate that this change will have any effect because the test suite operates against a public repo and thus does not test the auth stack in any way.

You may also want to cherry-pick abcb73f since that will set the default mode to oauth, giving us faster adoption of the mode in VFS for Git customers.