Update and futureproofing of ConfigureVisualStudio by tyrielv · Pull Request #1833 · microsoft/VFSForGit (original) (raw)

Nice! In microsoft/git, we extended this list, too albeit by hard-coding the version numbers.

Interesting! I'd have expected this to already cover the users that were having issues with this. On my machine those registry keys for up to 20.0 exist, but GitPath value is only set for 15.0 and 16.0.

I've uninstalled/reinstalled git several times testing things, so I wonder if those values were added on first install, removed on uninstall, but not added back on later reinstall.

Edit: Did some experimenting - if I install microsoft/git using the installer from the releases page, clicking through the installer UI, then it sets those keys. If I install it with winget (silent install), it does not set the keys.

Edit2: After some more experimenting, it's the /COMPONENTS=icons,ext,gitlfs,assoc,assoc_sh,consolefont,windowsterminal,scalar in winget config that is causing the post-install script not to run.

Edit3: The default set of components also includes autoupdate. Since the custom installer is explicitly inserted after InstallAutoUpdater, I but it's part of that component. I'll file an issue on microsoft/git.