Add support for publishing a single file executable by skylarnam · Pull Request #12 · microsoft/VSConfigFinder (original) (raw)
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
We need to make sure to publish a single file executable for signing.
Did you want to add the publish step to the builds now, or plan on doing that later?
Did you want to add the publish step to the builds now, or plan on doing that later?
I wanted to add that in a separate PR, since we don't have a clear idea how to do the signing step yet and I believe those two changes will be made in the same file, right?
Did you want to add the publish step to the builds now, or plan on doing that later?
I wanted to add that in a separate PR, since we don't have a clear idea how to do the signing step yet and I believe those two changes will be made in the same file, right?
Either way is fine, I don't expect much to change in the build when signing happens vs. just a publish now
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
