Running validation workflow in consolidate by sfoslund · Pull Request #1118 · microsoft/sbom-tool (original) (raw)
Conversation
This PR adds logic to run the validation workflow for each SBOM provided in the consolidate command. Some things to note about this implementation:
- It updates telemetry to differentiate between validation failures for different SBOMs using an identifier. For example:
... Errors=ErrorContainer`1 {Count=8, Errors=[FileValidationResult {Path="./extra/file", ErrorType=AdditionalFile, Identifier="334415413"}, FileValidationResult {Path="./extra/file", ErrorType=AdditionalFile, Identifier="548817155"}]}, ....
- It writes all validation results both to output files in the temp dir and to stdout
This PR changes files in the API project. Does it change any of the API interfaces in any way? Please note that this includes the following types of changes:
- Changing the signature of an existing interface method
- Adding a new method to an existing interface
- Adding a required data member to a class that an existing interface method consumes
Because any of these changes can potentially break a downstream consumer with customized interface implementations, these changes need to be treated as breaking changes. Please do one of the following:
Option 1 - Publish this as a breaking change
- Update the documentation to show the new functionality
- Bump the major version in the next release
- Be sure to highlight the breaking changes in the release notes
Option 2 - Refactor the changes to be non-breaking
- Review this commit, which adds a new interface in a backward-compatible way
- Refactor the change to follow this pattern so that existing interfaces are left completely intact
- Bump the minor version in the next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
2 participants
