Switch DataTestMethod to TestMethod by Youssef1313 · Pull Request #849 · microsoft/sbom-tool (original) (raw)

@Youssef1313

DataTestMethodAttribute is functionally the same as TestMethodAttribute and they are interchangeable. Using DataTestMethodAttribute is no longer recommended and may be dropped in MSTest v4.

@Youssef1313

@Youssef1313

@codecov-commenter

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.47%. Comparing base (9ef64aa) to head (acc244f).

Additional details and impacted files

@@ Coverage Diff @@ ## main #849 +/- ##

Coverage 46.47% 46.47%

Files 355 355
Lines 14151 14151
Branches 1163 1163

Hits 6577 6577
Misses 7026 7026
Partials 548 548

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DaveTryon

DaveTryon

DaveTryon

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @Youssef1313! I've requested a minor change just to follow consistent formatting in the test layout

@DaveTryon

DaveTryon

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for losing track of this, @Youssef1313! Thanks for the contribution :)

@DaveTryon

@DaveTryon

Minor tweaks for consistency

@DaveTryon

JoseRenan

@DaveTryon

Closing and reopening to see if that gets the PR build to trigger

DaveTryon added a commit that referenced this pull request

Jan 17, 2025

@DaveTryon

@sfoslund

@sfoslund

@sfoslund

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})