Update MSTest to metapackage and MTP by Youssef1313 · Pull Request #881 · microsoft/sbom-tool (original) (raw)

@DaveTryon it seems that E2E tests were not run before and now they are run causing the timeout. Is this expected that they run or not?

That's an interesting question. the unit tests only target net472 on Windows, but the e2e tests target net472 everywhere. The test runner, though, ignores the non-Windows net472 tests, so whether it's intentional or not, the net472 tests are effectively limited to Windows. I've sent a message to the team to see if they're OK with codifying the de facto behavior.

I did some experimenting in a branch based on your fork, and made 2 commits that you can backport to get past the test failures:

• This commit follows the pattern from the unit tests
• This commit gives MTP a test that succeeds, since apparently it treats it as a failure if all tests are skipped. There may also be a command line way to do this

After these commits are added, we still get an error because each stage is trying to upload to the same artifact name, and only the first one can win. Let's just go with code coverage results from Windows, since it's the platform with the broadest coverage