Add option: include command in screencast overlay by PEZ · Pull Request #126742 · microsoft/vscode (original) (raw)

@joaomoreno:

Isn't description set for most commands?

The problem I am hitting is not a lack of description. Yet. The CommanRegisitry has ICommands, where I think I need ICommandActions. That said, I don't see much in the way of description either.

If I pick out one command from each registry like so:

const command = shortcut?.commandId ? MenuRegistry.getCommand(shortcut.commandId) : null; const command2 = shortcut?.commandId ? CommandsRegistry.getCommand(shortcut.commandId) : null;

Logging them out shows this for some different commands:

MenuRegistry-command: undefined
CommandRegistry-command: {"id":"editor.action.smartSelect.expand"}

MenuRegistry-command: undefined
CommandRegistry-command: {"id":"editor.action.addSelectionToNextFindMatch"}

MenuRegistry-command: {"id":"paredit.forwardUpSexp","title":"Forward Up Sexp","category":"Calva Paredit","precondition":{"key":"editorLangId","value":"clojure","type":4}}
CommandRegistry-command: {"id":"paredit.forwardUpSexp"}

MenuRegistry-command: {"id":"calva.evaluateCurrentTopLevelForm","title":"Evaluate Top Level Form (defun)","category":"Calva","precondition":{"key":"calva:connected","type":2}}
CommandRegistry-command: {"id":"calva.evaluateCurrentTopLevelForm"}

MenuRegistry-command: {"id":"workbench.action.showCommands","title":{"value":"Show All Commands","original":"Show All Commands"}}
CommandRegistry-command: {"id":"workbench.action.showCommands"}

MenuRegistry-command: undefined
CommandRegistry-command: {"id":"workbench.action.closeQuickOpen","weight":200,"when":{"key":"inQuickOpen","type":2},"primary":9,"secondary":[1033]}

Maybe the real fix is to have more commands registered in the MenuRegistry? But seems a bit out of scope for this PR, WDYT?