Honor setting show only shortcut keys by PEZ · Pull Request #136251 · microsoft/vscode (original) (raw)

Now it works such that:

For screencastMode.onlyKeyboardShortcuts is false => show all keys pressed

ForscreencastMode.onlyKeyboardShortcuts is true, and we have a shortcut command =>

• Format is keys => Show keys
• Format is command => Show command title if we have it, otherwise keys (”same" for commandWithGroup)
• Format is commandAndKeys => Show command + keys if we have a command title, otherwise just keys ("same" for commandWithGroupAndKeys)

What tripped us up was probably the settings semantics talking about shortcut, but in the implementation semantics that is a shortcut with a commandId. (I.e. the first part of a chord for a shortcut command is a shortcut.) I don't know what we should be calling it instead.