Break infinite restore loop in VS by nohwnd · Pull Request #15503 · microsoft/vstest (original) (raw)
Pull request overview
Implements a workaround for dotnet/arcade#16228 by preventing Visual Studio from entering an infinite NuGet restore loop caused by a property name collision for the Microsoft.VSSDK.BuildTools version.
Changes:
- Renames the
Microsoft.VSSDK.BuildToolsversion MSBuild property to a collision-resistant name (_MicrosoftVSSDKBuildToolsVersion_). - Updates
Microsoft.TestPlatform.csprojto consume the new property name. - Adds a repo-wide
PackageReference Updateto pin/overrideMicrosoft.VSSDK.BuildToolsto the intended version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/package/Microsoft.TestPlatform/Microsoft.TestPlatform.csproj | Switches the Microsoft.VSSDK.BuildTools version to the new underscore-delimited property. |
| eng/Versions.props | Introduces _MicrosoftVSSDKBuildToolsVersion_ and documents the restore-loop workaround. |
| Directory.Build.targets | Adds a repo-wide PackageReference Update to ensure the pinned build tools version is applied. |