Fix orientation details export by aminemindee · Pull Request #1022 · mindee/doctr (original) (raw)
Hello this PR is to deal with the problem discussed here: #973
- Add orientation computation and output it
- Add language detection model
- Add it to predictor and output result
- Add tests
frgfm previously requested changes Aug 16, 2022
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR and taking care of this!
I added a few comments but here is some high level feedback:
- I feel like this PR should be split in two: keeping this one about orientation, and opening an other for language detection (I highly suggest opening a GH issue to discuss how this should be done before going for the PR)
- the PR adds a dependency, we need to be gradually more careful about this. Hence my suggestion about design discussion in an issue :)
- you added a binary file in the PR "lid.176.ftz". I think this isn't on purpose, but we need to remove it 😅
Cheers ✌️
Fix/orient lang details Fix orientation details export
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the suggested changes from @frgfm
Only to remove fasttext than looks good to me 👍
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aminemindee sry my mistake we need to add a short docstring for OCRPredictor in doctr/models/predictor/ (pytorch & tensorflow)
something like:
detect_orientation: if True, the estimated general page orientation will be added to the predictions for each page. Doing so will slightly deteriorate the overall latency.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aminemindee Thanks a lot for applying all changes 👍
There seems to be a problem with GH Actions currently will check it later again to merge :)
Hi @aminemindee 👋,
the Actions issue on GH side has destroyed anything .. build actions stucks in a Queue and i cannot trigger or cancel it (same for manual merge) 😅
Could you please push again that we can rerun CI
git commit --allow-empty -m "trigger CI"
than push again should work without any changes :)
@frgfm could you check this please i'm not able to merge this PR 🤔 (manual i get also an error: At least 1 approving review is required by reviewers with write access. 🤔 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})