Updated README.md for custom fonts by carl-krikorian · Pull Request #1051 · mindee/doctr (original) (raw)
As per discussion #1046 a small description of how to train using custom fonts has been added to the README.md of references/recognition.
As per discussion mindee#1046 a small description of how to train using custom fonts has been added to the README.md of references/recognition.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @carl-krikorian 👋 thanks for the PR i have added 2 small points :)
Codecov Report
Merging #1051 (95dff3b) into main (1cc073d) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #1051 +/- ##
Coverage 94.94% 94.94%
Files 135 135
Lines 5634 5634
Hits 5349 5349
Misses 285 285
| Flag | Coverage Δ |
|---|---|
| unittests | 94.94% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Made a few changes to the documentation as per the review.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the opportunity! It's been a pleasure.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I added a few comments
| Running the training script should look like this for multiple custom fonts: |
| ```shell |
| python references/recognition/train_pytorch.py crnn_vgg16_bn --epochs 5 --font "cusomt-font-1.ttf,custom-font-2.ttf" |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo here "custom-font-1.ttf" :)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Not very familiar with how I can fix this after the pull request was merged, do I need to create a new one? Or can I still push the changes from my branch? (I've tried this but doesn't seem to be an option).
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})