[Datasets] Add Vietnamese letters by MinhChien9 · Pull Request #1693 · mindee/doctr (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@MinhChien9

This PR:

@MinhChien9

@felixdittrich92

Hi @MinhChien9 👋,

Thanks for the PR 👍

Could you please shortly explain what was wrong within the current vietnamese vocab ? 😅

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (8e95e2f) to head (e88a2e5).

Additional details and impacted files

@@ Coverage Diff @@ ## main #1693 +/- ##

Flag Coverage Δ
unittests 96.38% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MinhChien9

Hi @MinhChien9 👋,

Thanks for the PR 👍

Could you please shortly explain what was wrong within the current vietnamese vocab ? 😅

It is missing the letters đ and Đ

felixdittrich92

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels

2 participants

@MinhChien9 @felixdittrich92