http: fix release race between cache and snapshot by tonistiigi · Pull Request #6292 · moby/buildkit (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tonistiigi

Fix issue where reference pulled for HTTP URL cache key digest computation can be released before the Snapshot method of the same step runs. This can cause duplicate pulls, or if data has changed upstream it would return "digest mismatch" error.

@tonistiigi

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@tonistiigi

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@tonistiigi

Fixes issue where HTTP result can be released after metadata resolve and rest of the build might pull new (potentially different) data in again.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@tonistiigi

Pushed additional fix for a similar case in relation to race between metadata resolve and cache/snapshot of the same URL.

crazy-max

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels

2 participants

@tonistiigi @crazy-max